From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lukasz Majewski <l.majewski@samsung.com>
Date: Mon, 30 Apr 2012 17:46:30 +0200
Subject: [U-Boot] [PATCH v4 RESEND 3/3] usb:udc:samsung Add functions
 for storing private gadget data in UDC driver
In-Reply-To: <20120430152342.EC15720021A@gemini.denx.de>
References: <1334762811-23068-4-git-send-email-l.majewski@samsung.com>
	<1335797479-1091-1-git-send-email-l.majewski@samsung.com>
	<20120430152342.EC15720021A@gemini.denx.de>
Message-ID: <20120430174630.2679cc31@lmajewski.digital.local>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Wolfgang,


> Dear Lukasz Majewski,
> 
> In message <1335797479-1091-1-git-send-email-l.majewski@samsung.com>
> you wrote:
> > This commit adds support for storing private data to Samsung's UDC
> > driver. This data is afterward used by usb gadget.
> > 
> > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> > Cc: Marek Vasut <marex@denx.de>
> ...
> > --- a/drivers/usb/gadget/s3c_udc_otg.c
> > +++ b/drivers/usb/gadget/s3c_udc_otg.c
> > @@ -30,7 +30,7 @@
> >   * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
> > 02111-1307  USA *
> >   */
> > -
> > +#undef DEBUG
> 
> Sorry, but please do not define what is not defined anyway.
> 
> > +void set_udc_gadget_private_data(void *p)
> > +{
> > +	debug("%s: the_controller: 0x%p, p: 0x%p\n", __func__,
> > +	       the_controller, p);
> > +	the_controller->gadget.dev.device_data = p;
> > +}
> 
> Hm... you chose the easy way.

:-)

> 
> My hope was that you would pick up my hint and keep the functionality,
> and just convert it to debug_cond() instead.
> 
> For example, as is DEBUG_SETUP() would become "active" only when
> DEBUG_S3C_UDC_SETUP is defined; see "include/usb/s3c_udc.h".  If we
> change the plain "#define DEBUG_S3C_UDC_SETUP" into a 
> "#define DEBUG_S3C_UDC_SETUP 1", then we can replace all use of
> 
> 	DEBUG_SETUP(foo, ...);
> 
> by the standard
> 
> 	debug_cond(DEBUG_S3C_UDC_SETUP != 0, foo, ...);
> 
> And similar for all the other DEBUG_S3C_* macros in
> "include/usb/s3c_udc.h"
> 
> That would be much more useful, wouldn't it?
> 

Thank you for detailed debug_cond explanation.

I will look into the code and refactor it.


-- 
Best regards,

Lukasz Majewski

Samsung Poland R&D Center | Linux Platform Group