From: Takuya Yoshikawa <takuya.yoshikawa@gmail.com>
To: Avi Kivity <avi@redhat.com>
Cc: mtosatti@redhat.com, kvm@vger.kernel.org, yoshikawa.takuya@oss.ntt.co.jp
Subject: Re: [PATCH 1/2] KVM: x86 emulator: Move ModRM flags for groups to top level opcode tables
Date: Mon, 30 Apr 2012 23:20:08 +0900 [thread overview]
Message-ID: <20120430232008.a26023ae96917d08e56752e0@gmail.com> (raw)
In-Reply-To: <4F9E69ED.7060601@redhat.com>
On Mon, 30 Apr 2012 13:31:09 +0300
Avi Kivity <avi@redhat.com> wrote:
> > static struct opcode group7_rm1[] = {
> > - DI(SrcNone | ModRM | Priv, monitor),
> > - DI(SrcNone | ModRM | Priv, mwait),
> > + DI(SrcNone | Priv, monitor),
> > + DI(SrcNone | Priv, mwait),
> > N, N, N, N, N, N,
> > };
> >
>
> Removing ModRM everywhere isn't strictly necessary (but is okay).
As ModRMs were inconsistently distributed, I wanted to make them
consistent.
If they are consistently written in everywhere, I like that style too!
Takuya
next prev parent reply other threads:[~2012-04-30 14:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-30 8:43 [PATCH 0/2 v2] KVM: x86 emulator: Simplify ModRM fetching Takuya Yoshikawa
2012-04-30 8:46 ` [PATCH 1/2] KVM: x86 emulator: Move ModRM flags for groups to top level opcode tables Takuya Yoshikawa
2012-04-30 10:31 ` Avi Kivity
2012-04-30 14:20 ` Takuya Yoshikawa [this message]
2012-04-30 8:48 ` [PATCH 2/2 v2] KVM: x86 emulator: Avoid pushing back ModRM byte fetched for group decoding Takuya Yoshikawa
2012-04-30 10:33 ` [PATCH 0/2 v2] KVM: x86 emulator: Simplify ModRM fetching Avi Kivity
2012-05-06 13:16 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120430232008.a26023ae96917d08e56752e0@gmail.com \
--to=takuya.yoshikawa@gmail.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.