From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 19/24] drm/i915: detect digital outputs on Haswell Date: Tue, 1 May 2012 08:01:08 -0700 Message-ID: <20120501080108.6b12702f@jbarnes-desktop> References: <1335464479-648-1-git-send-email-eugeni.dodonov@intel.com> <1335464479-648-20-git-send-email-eugeni.dodonov@intel.com> <20120430172750.2f3340f3@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy8-pub.bluehost.com (oproxy8-pub.bluehost.com [69.89.22.20]) by gabe.freedesktop.org (Postfix) with SMTP id 45B209E885 for ; Tue, 1 May 2012 08:01:11 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Eugeni Dodonov Cc: intel-gfx@lists.freedesktop.org, Eugeni Dodonov List-Id: intel-gfx@lists.freedesktop.org On Mon, 30 Apr 2012 21:33:42 -0300 Eugeni Dodonov wrote: > On Mon, Apr 30, 2012 at 21:27, Jesse Barnes wrote: > > > We really really need to get the port detection working on HSW using > > the VBT. > > > > It is not that easy from what I've seen. VBT can give some hints on which > ports can support only DP or HDMI, but it does not answers all the cases. > So the best solution seems to be running a DP AUX query when we got an > output, and if it succeeds - it is a DP; otherwise, it is HDMI. > > So my idea here is: > - add both HDMI and DP connectors for each available port (those we can > get via VBT and from the GPU variant - some variants don't have specific > DDIs in hardware, and VBT can further say which DDI are incapable of > driving HDMI when present) > - add an intel_ddi_detect routine for .detect of each of them > - the intel_ddi_detect would try doing the DP AUX test, and dispatch > either intel_hdmi_detect or intel_dp_detect accordingly. > > Once the DP code will be ready, we'll put this in place. But for now, only > HDMI works anyway, and I don't have any DP monitor around to play with :). > > Does this looks reasonable? I had wanted to avoid every HSW system looking like it had a bunch of HDMI and DP ports, when it really only has one of each or something. -- Jesse Barnes, Intel Open Source Technology Center