From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760713Ab2EDXz4 (ORCPT ); Fri, 4 May 2012 19:55:56 -0400 Received: from mail-pz0-f45.google.com ([209.85.210.45]:51471 "EHLO mail-pz0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756752Ab2EDXzy (ORCPT ); Fri, 4 May 2012 19:55:54 -0400 Date: Fri, 4 May 2012 16:55:50 -0700 From: Greg KH To: Alan Cox Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH 3/3] tty_lock: Localise the lock Message-ID: <20120504235550.GA5727@kroah.com> References: <20120503212151.568.91854.stgit@bob.linux.org.uk> <20120503212219.568.15653.stgit@bob.linux.org.uk> <20120504235412.GA5694@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120504235412.GA5694@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 04, 2012 at 04:54:12PM -0700, Greg KH wrote: > On Thu, May 03, 2012 at 10:24:08PM +0100, Alan Cox wrote: > > From: Alan Cox > > > > In each remaining case the tty_lock is associated with a specific tty. This > > means we can now lock on a per tty basis. We do need tty_lock_pair() for > > the pty case. Uglier but still a step in the right direction. > > > > Signed-off-by: Alan Cox > > Acked-by: Arnd Bergmann > > --- > > > > drivers/tty/amiserial.c | 12 ++++---- > > drivers/tty/cyclades.c | 2 + > > drivers/tty/n_r3964.c | 11 ++++--- > > drivers/tty/pty.c | 23 +++++++++------ > > drivers/tty/synclink.c | 4 +-- > > drivers/tty/synclink_gt.c | 4 +-- > > drivers/tty/synclinkmp.c | 4 +-- > > drivers/tty/tty_io.c | 67 +++++++++++++++++++++++++++------------------ > > drivers/tty/tty_ldisc.c | 30 ++++++++++---------- > > drivers/tty/tty_mutex.c | 60 ++++++++++++++++++++++++++++++---------- > > drivers/tty/tty_port.c | 6 ++-- > > include/linux/tty.h | 23 +++++++++------ > > 12 files changed, 149 insertions(+), 97 deletions(-) > > You forgot the call in net/bluetooth/rfcomm/tty.c, I'll go fix that > up... And drivers/tty/serial/crisv10.c and drivers/staging/serial/68360serial.c...