From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35482) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SQSaQ-0000Bu-Ia for qemu-devel@nongnu.org; Fri, 04 May 2012 20:10:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SQSaO-0004WZ-SU for qemu-devel@nongnu.org; Fri, 04 May 2012 20:10:58 -0400 Received: from mail-qa0-f45.google.com ([209.85.216.45]:35115) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SQSaO-0004VS-Od for qemu-devel@nongnu.org; Fri, 04 May 2012 20:10:56 -0400 Received: by qaeb19 with SMTP id b19so1367276qae.4 for ; Fri, 04 May 2012 17:10:54 -0700 (PDT) Date: Fri, 4 May 2012 20:10:52 -0400 From: Kevin O'Connor Message-ID: <20120505001052.GA26365@morn.localdomain> References: <1336119687-6295-1-git-send-email-kraxel@redhat.com> <1336119687-6295-2-git-send-email-kraxel@redhat.com> <20120504131546.GA668@morn.localdomain> <4FA3F72E.7080103@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4FA3F72E.7080103@redhat.com> Subject: Re: [Qemu-devel] [SeaBIOS] [seabios patch 1/5] pci: init all devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: seabios@seabios.org, qemu-devel@nongnu.org On Fri, May 04, 2012 at 05:35:10PM +0200, Gerd Hoffmann wrote: > On 05/04/12 15:15, Kevin O'Connor wrote: > > On Fri, May 04, 2012 at 10:21:23AM +0200, Gerd Hoffmann wrote: > >> seabios used to initialize root bus devices only, with this patch > >> devices behind pci bridges are initialized too. This allows to boot > >> from virtio devices behind pci bridges. [...] > > I think this will then assign an incorrect PCI_INTERRUPT_LINE value to > > non root bus devices. > > Attached patch should fix it if I read the specs correctly. > Untested though, review appreciated. It looks good to me from a read of the spec as well. I'm not sure how to test it. -Kevin