From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Subject: Re: [PATCH v2 2/5] dma: mxs-dma: make platform_device_id more generic Date: Sat, 5 May 2012 16:32:14 +0200 Message-ID: <201205051632.14882.marex@denx.de> References: <1336133539-13465-1-git-send-email-b29396@freescale.com> <201205051512.17972.marex@denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Shawn Guo Cc: vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org, b32955-KZfg59tc24xl57MIdRCFDg@public.gmane.org, kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Dear Shawn Guo, > On 5 May 2012 21:12, Marek Vasut wrote: > > Can't the patches be reordered then to avoid adding this altogether? > > Maybe. But I do not think it's really worth the effort. > > > You don't have to add dead code in this patch and re-add it when needed. > > Or fix the macro to take the parameter then, though I don't understand > > why you'd want to take it and then hide it. > > I do not completely understand the comment. My point is the problem > is in the existing code. It's not introduced by Dong's patch. The > problem should be fixed in another patch, and we do not want to do > several things in one patch. Then order such a patch before Dong's series then? It'd all be clear, without compromises. > > Regards, > Shawn Best regards, Marek Vasut From mboxrd@z Thu Jan 1 00:00:00 1970 From: marex@denx.de (Marek Vasut) Date: Sat, 5 May 2012 16:32:14 +0200 Subject: [PATCH v2 2/5] dma: mxs-dma: make platform_device_id more generic In-Reply-To: References: <1336133539-13465-1-git-send-email-b29396@freescale.com> <201205051512.17972.marex@denx.de> Message-ID: <201205051632.14882.marex@denx.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Dear Shawn Guo, > On 5 May 2012 21:12, Marek Vasut wrote: > > Can't the patches be reordered then to avoid adding this altogether? > > Maybe. But I do not think it's really worth the effort. > > > You don't have to add dead code in this patch and re-add it when needed. > > Or fix the macro to take the parameter then, though I don't understand > > why you'd want to take it and then hide it. > > I do not completely understand the comment. My point is the problem > is in the existing code. It's not introduced by Dong's patch. The > problem should be fixed in another patch, and we do not want to do > several things in one patch. Then order such a patch before Dong's series then? It'd all be clear, without compromises. > > Regards, > Shawn Best regards, Marek Vasut