From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/2] drm/i915: Support pageflipping interrupts for all 3-pipes on IVB Date: Sun, 6 May 2012 17:34:53 +0200 Message-ID: <20120506153452.GA4756@phenom.ffwll.local> References: <1335948733-20561-1-git-send-email-chris@chris-wilson.co.uk> <20120502124642.2ec29c9b@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f177.google.com (mail-we0-f177.google.com [74.125.82.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 072CD9E9F7 for ; Sun, 6 May 2012 08:33:56 -0700 (PDT) Received: by werp11 with SMTP id p11so3249074wer.36 for ; Sun, 06 May 2012 08:33:56 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20120502124642.2ec29c9b@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, May 02, 2012 at 12:46:42PM -0700, Jesse Barnes wrote: > On Wed, 2 May 2012 09:52:12 +0100 > Chris Wilson wrote: > > > Signed-off-by: Chris Wilson > > --- > > drivers/gpu/drm/i915/i915_irq.c | 31 ++++++++++++++++++++++--------- > > drivers/gpu/drm/i915/i915_reg.h | 7 +++++-- > > 2 files changed, 27 insertions(+), 11 deletions(-) > > > > Highly embarrassing. > > Reviewed-by: Jesse Barnes Even more embarrassing that I've failed to pick this up until I've noticed that lack of a merge conflict that should be there when mergin in -fixes. We really need some automated tests to check whether pageflipping actually works on all crtcs ... -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48