[PATCH 1/2] mfd: max8925: request resource region - Russell King

From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] mfd: max8925: request resource region
Date: Mon, 7 May 2012 09:59:23 +0100	[thread overview]
Message-ID: <20120507085923.GM26481@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CAN1soZzj1FKhFPHOUjbARpzuA1_vB4TO0O8ThCiG49nPqYqCwg@mail.gmail.com>

On Mon, May 07, 2012 at 04:18:40PM +0800, Haojian Zhuang wrote:
> On Mon, May 7, 2012 at 3:58 PM, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
> > On Mon, May 07, 2012 at 11:10:48AM +0800, Haojian Zhuang wrote:
> >> If resource region isn't requested, component devices will fail to request
> >> their resources.
> >>
> >> Signed-off-by: Haojian Zhuang <haojian.zhuang@gmail.com>
> >
> > This looks wrong.
> >
> > This driver looks broken. ?IO regions are for PC IO stuff, not for I2C
> > buses. ?There is no resource reservation system in the kernel for
> > registers on I2C devices.
> 
> There's some components in PMIC devices. I used IO resources to
> identify these components,
> and these IO resources are register offset in PMIC. But if I choose
> MEM resources, it may
> conflict with real memory resources. So I choose IO resources. Do you
> have any other implementation
> instead?

Which is wrong as I've said above.  This needs discussing and fixing;
this driver should never have been merged with this abuse in.