From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric =?ISO-8859-1?B?QuluYXJk?= Subject: Re: [PATCH] can: flexcan: add PM support Date: Tue, 8 May 2012 19:14:59 +0200 Message-ID: <20120508191459.703c4369@eb-e6520> References: <1336489937-29645-1-git-send-email-eric@eukrea.com> <4FA9394A.90303@pengutronix.de> <20120508173001.31ce8f0c@eb-e6520> <4FA93FC1.7030808@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from smtp3-g21.free.fr ([212.27.42.3]:36989 "EHLO smtp3-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756476Ab2EHRPK convert rfc822-to-8bit (ORCPT ); Tue, 8 May 2012 13:15:10 -0400 In-Reply-To: <4FA93FC1.7030808@pengutronix.de> Sender: linux-can-owner@vger.kernel.org List-ID: To: Marc Kleine-Budde Cc: linux-can@vger.kernel.org, Sascha Hauer , Wolfgang Grandegger Le Tue, 08 May 2012 17:46:09 +0200, Marc Kleine-Budde a =E9crit : > On 05/08/2012 05:30 PM, Eric B=E9nard wrote: > > Hi Marc, > >=20 > > Le Tue, 08 May 2012 17:18:34 +0200, > > Marc Kleine-Budde a =E9crit : > >=20 > >> On 05/08/2012 05:12 PM, Eric B=E9nard wrote: > >>> tested on an i.MX257 > >> > >> What about the transceiver? Does is make sense to switch it off, t= oo? > >> > > this could make sense on platform which have a transceiver with an > > enable input. I can add flexcan_transceiver_switch after/before > > flexcan_chip_disable/enable but won't be able to test that feature. >=20 > I looked at two ethernet drivers: ethernet/intel/ixgbe/ixgbe_main.c a= nd > ethernet/intel/ixgbe/ixgbe_main.c and AFAICS they basically do the sa= me > as in open/close. (btw: the flexcan driver switches the transceiver > on/off on open/close.) I haven't implemented any network driver pm ye= t, > but what is a driver supposed to do in suspend/resume? >=20 concerning the transceiver : that depends if you need to resume when receiving a message on the CAN bus in which case you can't disable the transceiver (btw, I have an other patch which enable wakeup when receiving a message on the CAN bus, but I need to clean and test it again). Eric