From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759100Ab2EKXi3 (ORCPT ); Fri, 11 May 2012 19:38:29 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:39833 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755101Ab2EKXi0 (ORCPT ); Fri, 11 May 2012 19:38:26 -0400 Date: Fri, 11 May 2012 16:38:21 -0700 From: Greg KH To: Alex Williamson Cc: benh@kernel.crashing.org, aik@ozlabs.ru, david@gibson.dropbear.id.au, joerg.roedel@amd.com, dwmw2@infradead.org, chrisw@sous-sol.org, agraf@suse.de, benve@cisco.com, aafabbri@cisco.com, B08248@freescale.com, B07421@freescale.com, avi@redhat.com, konrad.wilk@oracle.com, kvm@vger.kernel.org, qemu-devel@nongnu.org, iommu@lists.linux-foundation.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, bhelgaas@google.com Subject: Re: [PATCH 01/13] driver core: Add iommu_group tracking to struct device Message-ID: <20120511233821.GA9335@kroah.com> References: <20120511222148.30496.68571.stgit@bling.home> <20120511225534.30496.54563.stgit@bling.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120511225534.30496.54563.stgit@bling.home> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 11, 2012 at 04:55:35PM -0600, Alex Williamson wrote: > IOMMU groups allow IOMMU drivers to represent DMA visibility > and isolation of devices. Multiple devices may be grouped > together for the purposes of DMA. Placing a pointer on > struct device enable easy access for things like streaming > DMA programming and drivers like VFIO. > > Signed-off-by: Alex Williamson Can't you get this today from the iommu_ops pointer that is on the bus that the device is associated with? Or can devices on a bus have different iommu_group pointers? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52526) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSzPr-0004BI-H2 for qemu-devel@nongnu.org; Fri, 11 May 2012 19:38:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SSzPp-0007j4-Q2 for qemu-devel@nongnu.org; Fri, 11 May 2012 19:38:31 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:34871) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSzPp-0007in-KG for qemu-devel@nongnu.org; Fri, 11 May 2012 19:38:29 -0400 Received: by pbbro12 with SMTP id ro12so5292189pbb.4 for ; Fri, 11 May 2012 16:38:26 -0700 (PDT) Date: Fri, 11 May 2012 16:38:21 -0700 From: Greg KH Message-ID: <20120511233821.GA9335@kroah.com> References: <20120511222148.30496.68571.stgit@bling.home> <20120511225534.30496.54563.stgit@bling.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120511225534.30496.54563.stgit@bling.home> Subject: Re: [Qemu-devel] [PATCH 01/13] driver core: Add iommu_group tracking to struct device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: aafabbri@cisco.com, kvm@vger.kernel.org, B07421@freescale.com, aik@ozlabs.ru, konrad.wilk@oracle.com, linux-pci@vger.kernel.org, agraf@suse.de, qemu-devel@nongnu.org, chrisw@sous-sol.org, B08248@freescale.com, iommu@lists.linux-foundation.org, avi@redhat.com, joerg.roedel@amd.com, bhelgaas@google.com, benve@cisco.com, dwmw2@infradead.org, linux-kernel@vger.kernel.org, david@gibson.dropbear.id.au On Fri, May 11, 2012 at 04:55:35PM -0600, Alex Williamson wrote: > IOMMU groups allow IOMMU drivers to represent DMA visibility > and isolation of devices. Multiple devices may be grouped > together for the purposes of DMA. Placing a pointer on > struct device enable easy access for things like streaming > DMA programming and drivers like VFIO. > > Signed-off-by: Alex Williamson Can't you get this today from the iommu_ops pointer that is on the bus that the device is associated with? Or can devices on a bus have different iommu_group pointers? thanks, greg k-h