All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Anton Vorontsov <anton.vorontsov@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Kees Cook <keescook@chromium.org>,
	Colin Cross <ccross@android.com>,
	devel@driverdev.osuosl.org, linaro-kernel@lists.linaro.org,
	Arnd Bergmann <arnd@arndb.de>,
	patches@linaro.org, Marco Stornelli <marco.stornelli@gmail.com>,
	Stephen Boyd <sboyd@codeaurora.org>,
	linux-kernel@vger.kernel.org, arve@android.com,
	Jesper Juhl <jj@chaosbits.net>,
	John Stultz <john.stultz@linaro.org>,
	Rebecca Schultz Zavin <rebecca@android.com>,
	WANG Cong <xiyou.wangcong@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	kernel-team@android.com, Thomas Meyer <thomas@m3y3r.de>
Subject: Re: [PATCH 02/11] persistent_ram: Fix buffer size clamping during writes
Date: Sun, 13 May 2012 19:56:01 +0300	[thread overview]
Message-ID: <20120513165601.GC16984@mwanda> (raw)
In-Reply-To: <20120512001717.GB14782@lizard>

On Fri, May 11, 2012 at 05:17:17PM -0700, Anton Vorontsov wrote:
> This is a longstanding bug, almost unnoticeable when calling
> persistent_ram_write() for small buffers.
> 
> But when called for large data buffers, the write routine behaves
> incorrectly, as the size may never update: instead of clamping
> the size to the maximum buffer size, buffer_size_add_clamp() returns
> an error (which is never checked by the write routine, btw).
> 
> To fix this, we now use buffer_size_add() that actually clamps the
> size to the max value.
> 
> Also remove buffer_size_add_clamp(), it is no longer needed.
> 

Say if you did notice it, what would that look like?  It's just that
something gets lost instead of written to the screen right?

regards,
dan carpenter



  reply	other threads:[~2012-05-13 16:53 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-12  0:15 [PATCH 0/11] Merge ramoops and persistent_ram, generic pstore RAM backend Anton Vorontsov
2012-05-12  0:17 ` [PATCH 01/11] persistent_ram: Remove prz->node Anton Vorontsov
2012-05-12  0:17 ` [PATCH 02/11] persistent_ram: Fix buffer size clamping during writes Anton Vorontsov
2012-05-13 16:56   ` Dan Carpenter [this message]
2012-05-13 20:38     ` Anton Vorontsov
2012-05-14  3:23   ` Colin Cross
2012-05-14  4:17     ` Greg Kroah-Hartman
2012-05-12  0:17 ` [PATCH 03/11] persistent_ram: Introduce persistent_ram_post_init() Anton Vorontsov
2012-05-12  0:17 ` [PATCH 04/11] persistent_ram: Introduce persistent_ram_new() Anton Vorontsov
2012-05-15  0:37   ` Colin Cross
2012-05-16  0:22     ` Anton Vorontsov
2012-05-12  0:17 ` [PATCH 05/11] persistent_ram: Introduce persistent_ram_vmap() Anton Vorontsov
2012-05-12  0:17 ` [PATCH 06/11] persistent_ram: Make it possible to use memory outside of bootmem Anton Vorontsov
2012-06-06 21:10   ` Colin Cross
2012-06-06 22:11     ` Anton Vorontsov
2012-05-12  0:18 ` [PATCH 07/11] persistent_ram: Introduce persistent_ram_free() Anton Vorontsov
2012-05-12  0:18 ` [PATCH 08/11] ramoops: Move to fs/pstore/ram.c Anton Vorontsov
2012-05-14 21:34   ` Kees Cook
2012-05-16  0:19     ` Anton Vorontsov
2012-05-15 15:12   ` Shuah Khan
2012-05-16  7:30     ` Anton Vorontsov
2012-05-16 15:17       ` Shuah Khan
2012-05-12  0:18 ` [PATCH 09/11] persistent_ram: Move to fs/pstore/ram_core.c Anton Vorontsov
2012-05-14 21:43   ` Kees Cook
2012-05-12  0:18 ` [PATCH 10/11] pstore/ram: Switch to persistent_ram routines Anton Vorontsov
2012-05-14 22:21   ` Kees Cook
2012-05-16  6:14     ` Anton Vorontsov
2012-05-16 12:44       ` Kees Cook
2012-05-12  0:18 ` [PATCH 11/11] pstore/ram: Add ECC support Anton Vorontsov
2012-05-14 22:22   ` Kees Cook
2012-05-14 15:58 ` [PATCH 0/11] Merge ramoops and persistent_ram, generic pstore RAM backend Greg Kroah-Hartman
2012-05-14 16:30   ` Shuah Khan
2012-05-14 20:45     ` Anton Vorontsov
2012-05-14 20:55       ` Shuah Khan
2012-05-15 15:53       ` Greg Kroah-Hartman
2012-05-15  6:07     ` Marco Stornelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120513165601.GC16984@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=anton.vorontsov@linaro.org \
    --cc=arnd@arndb.de \
    --cc=arve@android.com \
    --cc=ccross@android.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jj@chaosbits.net \
    --cc=john.stultz@linaro.org \
    --cc=keescook@chromium.org \
    --cc=kernel-team@android.com \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marco.stornelli@gmail.com \
    --cc=patches@linaro.org \
    --cc=rebecca@android.com \
    --cc=sboyd@codeaurora.org \
    --cc=thomas@m3y3r.de \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.