From: shawn.guo@freescale.com (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] gpio/generic: initialize the shadow of direction register
Date: Wed, 16 May 2012 15:29:00 +0800 [thread overview]
Message-ID: <20120516072859.GE21517@S2100-06.ap.freescale.net> (raw)
In-Reply-To: <20403.20214.297216.188300@ipc1.ka-ro>
On Wed, May 16, 2012 at 08:53:42AM +0200, Lothar Wa?mann wrote:
> > @@ -394,6 +394,10 @@ int bgpio_init(struct bgpio_chip *bgc, struct device *dev,
> > return ret;
> >
> > bgc->data = bgc->read_reg(bgc->reg_dat);
> > + if (bgc->gc.set == bgpio_set_set)
> > + bgc->data = bgc->read_reg(bgc->reg_set);
> > + if (bgc->reg_dir)
> > + bgc->dir = bgc->read_reg(bgc->reg_dir);
> >
> > return ret;
> > }
> >
> That might change the behaviour of existing implementations.
>
Can you be specific? I do not quite follow on that.
--
Regards,
Shawn
next prev parent reply other threads:[~2012-05-16 7:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 3:56 [PATCH] gpio/generic: initialize the shadow of direction register Shawn Guo
2012-05-15 7:17 ` Lothar Waßmann
2012-05-16 5:33 ` Shawn Guo
2012-05-16 6:53 ` Lothar Waßmann
2012-05-16 7:29 ` Shawn Guo [this message]
2012-05-16 7:34 ` Lothar Waßmann
2012-05-16 12:36 ` Shawn Guo
2012-05-16 12:48 ` Lothar Waßmann
2012-05-16 13:38 ` Shawn Guo
2012-05-16 13:33 ` Lothar Waßmann
2012-05-16 14:07 ` Shawn Guo
2012-05-16 14:03 ` Lothar Waßmann
2012-05-16 16:21 ` Shawn Guo
2012-05-16 13:54 ` Lothar Waßmann
2012-05-16 16:17 ` Shawn Guo
2012-05-17 20:39 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120516072859.GE21517@S2100-06.ap.freescale.net \
--to=shawn.guo@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.