From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753013Ab2EPODh (ORCPT ); Wed, 16 May 2012 10:03:37 -0400 Received: from mail-lb0-f174.google.com ([209.85.217.174]:56849 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751579Ab2EPODg (ORCPT ); Wed, 16 May 2012 10:03:36 -0400 Date: Wed, 16 May 2012 17:03:24 +0300 From: Shmulik Ladkani To: Richard Weinberger Cc: linux-mtd@lists.infradead.org, dedekind1@gmail.com, linux-kernel@vger.kernel.org, Heinz.Egger@linutronix.de, tim.bird@am.sony.com, tglx@linutronix.de Subject: Re: [PATCH 1/7] [RFC] UBI: Export next_sqnum() Message-ID: <20120516170324.337f2932@pixies.home.jungo.com> In-Reply-To: <1337101871-31181-2-git-send-email-richard@nod.at> References: <1337101871-31181-1-git-send-email-richard@nod.at> <1337101871-31181-2-git-send-email-richard@nod.at> X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.9; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Richard, On Tue, 15 May 2012 19:11:05 +0200 Richard Weinberger wrote: > The fastmap mechanism needs to read the next sequence nummber > directly. > > Signed-off-by: Richard Weinberger > --- > drivers/mtd/ubi/eba.c | 18 +++++++++--------- > drivers/mtd/ubi/ubi.h | 1 + > 2 files changed, 10 insertions(+), 9 deletions(-) > > diff --git a/drivers/mtd/ubi/eba.c b/drivers/mtd/ubi/eba.c > index bd5fdbf..d75677d 100644 > --- a/drivers/mtd/ubi/eba.c > +++ b/drivers/mtd/ubi/eba.c > @@ -57,7 +57,7 @@ > * global sequence counter value. It also increases the global sequence > * counter. > */ > -static unsigned long long next_sqnum(struct ubi_device *ubi) > +unsigned long long ubi_next_sqnum(struct ubi_device *ubi) Minor nit. Comment above the function should have been changed too. (look for the "next_sqnum - get next sequence number" comment) Other than that, Reviewed-by: Shmulik Ladkani Regards, Shmulik From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lpp01m010-f49.google.com ([209.85.215.49]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1SUepE-0000aN-Sb for linux-mtd@lists.infradead.org; Wed, 16 May 2012 14:03:38 +0000 Received: by laap9 with SMTP id p9so643178laa.36 for ; Wed, 16 May 2012 07:03:34 -0700 (PDT) Date: Wed, 16 May 2012 17:03:24 +0300 From: Shmulik Ladkani To: Richard Weinberger Subject: Re: [PATCH 1/7] [RFC] UBI: Export next_sqnum() Message-ID: <20120516170324.337f2932@pixies.home.jungo.com> In-Reply-To: <1337101871-31181-2-git-send-email-richard@nod.at> References: <1337101871-31181-1-git-send-email-richard@nod.at> <1337101871-31181-2-git-send-email-richard@nod.at> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dedekind1@gmail.com, linux-kernel@vger.kernel.org, Heinz.Egger@linutronix.de, linux-mtd@lists.infradead.org, tim.bird@am.sony.com, tglx@linutronix.de List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Richard, On Tue, 15 May 2012 19:11:05 +0200 Richard Weinberger wrote: > The fastmap mechanism needs to read the next sequence nummber > directly. > > Signed-off-by: Richard Weinberger > --- > drivers/mtd/ubi/eba.c | 18 +++++++++--------- > drivers/mtd/ubi/ubi.h | 1 + > 2 files changed, 10 insertions(+), 9 deletions(-) > > diff --git a/drivers/mtd/ubi/eba.c b/drivers/mtd/ubi/eba.c > index bd5fdbf..d75677d 100644 > --- a/drivers/mtd/ubi/eba.c > +++ b/drivers/mtd/ubi/eba.c > @@ -57,7 +57,7 @@ > * global sequence counter value. It also increases the global sequence > * counter. > */ > -static unsigned long long next_sqnum(struct ubi_device *ubi) > +unsigned long long ubi_next_sqnum(struct ubi_device *ubi) Minor nit. Comment above the function should have been changed too. (look for the "next_sqnum - get next sequence number" comment) Other than that, Reviewed-by: Shmulik Ladkani Regards, Shmulik