From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760865Ab2EQJjm (ORCPT ); Thu, 17 May 2012 05:39:42 -0400 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:42647 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758158Ab2EQJjk (ORCPT ); Thu, 17 May 2012 05:39:40 -0400 Date: Thu, 17 May 2012 10:39:21 +0100 From: Catalin Marinas To: Paul Mundt Cc: Peter Zijlstra , Andrea Arcangeli , Thomas Gleixner , Rik van Riel , Ingo Molnar , "akpm@linux-foundation.org" , Linus Torvalds , "linux-kernel@vger.kernel.org" , "linux-arch@vger.kernel.org" , "linux-mm@kvack.org" , Benjamin Herrenschmidt , David Miller , Hugh Dickins , Mel Gorman , Nick Piggin , Russell King , Chris Metcalf , Martin Schwidefsky Subject: Re: [RFC][PATCH 4/6] arm, mm: Convert arm to generic tlb Message-ID: <20120517093921.GB14666@arm.com> References: <20110302175928.022902359@chello.nl> <20110302180259.109909335@chello.nl> <20120517030551.GA11623@linux-sh.org> <20120517093022.GA14666@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120517093022.GA14666@arm.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 17, 2012 at 10:30:23AM +0100, Catalin Marinas wrote: > Another minor thing is that on newer ARM processors (Cortex-A15) we > need the TLB shootdown even on UP systems, so tlb_fast_mode should > always return 0. Something like below (untested): > > > diff --git a/arch/arm/include/asm/tlb.h b/arch/arm/include/asm/tlb.h > index 37dbce9..8e79689 100644 > --- a/arch/arm/include/asm/tlb.h > +++ b/arch/arm/include/asm/tlb.h > @@ -23,6 +23,10 @@ > > #include > > +#ifdef CONFIG_CPU_32v7 > +#define tlb_fast_mode (0) > +#endif > + > #include > > #else /* !CONFIG_MMU */ This hunk should have been a few lines down for the CONFIG_MMU case. -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx141.postini.com [74.125.245.141]) by kanga.kvack.org (Postfix) with SMTP id C4EED6B0044 for ; Thu, 17 May 2012 05:39:55 -0400 (EDT) Date: Thu, 17 May 2012 10:39:21 +0100 From: Catalin Marinas Subject: Re: [RFC][PATCH 4/6] arm, mm: Convert arm to generic tlb Message-ID: <20120517093921.GB14666@arm.com> References: <20110302175928.022902359@chello.nl> <20110302180259.109909335@chello.nl> <20120517030551.GA11623@linux-sh.org> <20120517093022.GA14666@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120517093022.GA14666@arm.com> Sender: owner-linux-mm@kvack.org List-ID: To: Paul Mundt Cc: Peter Zijlstra , Andrea Arcangeli , Thomas Gleixner , Rik van Riel , Ingo Molnar , "akpm@linux-foundation.org" , Linus Torvalds , "linux-kernel@vger.kernel.org" , "linux-arch@vger.kernel.org" , "linux-mm@kvack.org" , Benjamin Herrenschmidt , David Miller , Hugh Dickins , Mel Gorman , Nick Piggin , Russell King , Chris Metcalf , Martin Schwidefsky On Thu, May 17, 2012 at 10:30:23AM +0100, Catalin Marinas wrote: > Another minor thing is that on newer ARM processors (Cortex-A15) we > need the TLB shootdown even on UP systems, so tlb_fast_mode should > always return 0. Something like below (untested): > > > diff --git a/arch/arm/include/asm/tlb.h b/arch/arm/include/asm/tlb.h > index 37dbce9..8e79689 100644 > --- a/arch/arm/include/asm/tlb.h > +++ b/arch/arm/include/asm/tlb.h > @@ -23,6 +23,10 @@ > > #include > > +#ifdef CONFIG_CPU_32v7 > +#define tlb_fast_mode (0) > +#endif > + > #include > > #else /* !CONFIG_MMU */ This hunk should have been a few lines down for the CONFIG_MMU case. -- Catalin -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org