From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967235Ab2ERJBK (ORCPT ); Fri, 18 May 2012 05:01:10 -0400 Received: from mga14.intel.com ([143.182.124.37]:22542 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966510Ab2ERJBF (ORCPT ); Fri, 18 May 2012 05:01:05 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.71,315,1320652800"; d="scan'208";a="101562726" Date: Fri, 18 May 2012 11:10:59 +0200 From: Samuel Ortiz To: Alessandro Rubini Cc: grant.likely@secretlab.ca, linux-kernel@vger.kernel.org, giancarlo.asnaghi@st.com, alan@linux.intel.com, linus.walleij@stericsson.com Subject: Re: [PATCH V3 2/2] gpio: add STA2X11 GPIO block Message-ID: <20120518091059.GD12015@sortiz-mobl> References: <20120511233402.43D813E0791@localhost> <5e419c41c8e3bcbeac341aa9457a9c93bc4c8309.1334219874.git.rubini@gnudd.com> <20120514072534.GA29871@mail.gnudd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120514072534.GA29871@mail.gnudd.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alessandro, On Mon, May 14, 2012 at 09:25:34AM +0200, Alessandro Rubini wrote: > Hello Grant. Sorry for the delay. > > >> + /* 384 was used in previous code: be compatible for other drivers */ > >> + err = irq_alloc_descs(-1, 384, GSTA_NR_GPIO, NUMA_NO_NODE); > > > Where does the number 384 come from? It looks like the driver only > > needs to allocate a range of irqs and that it doesn't actually matter > > what the real numbers are. Can 0 be used instead? > > The problem is that there are a number of drivers already working (but > not ready to be upstreamed), and we'd better continue using them. So, > the mmc driver is requesting a specific interrupt number. The code is > GPL (published on sourceforge) and I'd better remain compatible. > > I'm not completely clear (yet) about how to get the right interrupt > number in those other drivers, but I'm willing to remove the constraint > as they are cleaned up and submitted. > > > Actually, I'd rather see this driver switched to using > > irq_domain_add_linear so that irq_descs can be allocated on demand > > instead of all at once. That way only gpios actually used for irqs > > get setup. > > If it is a request, I'll evaluate it soon. I assume an incremental > patch over what Samuel has already picked up is fine. That is fine with me at least. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/