All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Wim Van Sebroeck <wim@iguana.be>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Aaron Sierra <asierra@xes-inc.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Randy Dunlap <rdunlap@xenotime.net>
Subject: linux-next: manual merge of the watchdog tree with the mfd tree
Date: Fri, 18 May 2012 15:23:48 +1000	[thread overview]
Message-ID: <20120518152348.1e5070cdc16cfdf00682546d@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 2596 bytes --]

Hi Wim,

Today's linux-next merge of the watchdog tree got a conflict in
drivers/watchdog/iTCO_wdt.c between commit 887c8ec7219f ("watchdog:
Convert iTCO_wdt driver to mfd model") from the  tree and commit
c3614aa19d3e ("watchdog: iTCO_wdt.c: fix printk format warnings") from
the watchdog tree.

I fixed it up (see below) and can carry the fix as necessary.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

diff --cc drivers/watchdog/iTCO_wdt.c
index 741528b,2aab56f..0000000
--- a/drivers/watchdog/iTCO_wdt.c
+++ b/drivers/watchdog/iTCO_wdt.c
@@@ -572,33 -837,32 +572,33 @@@ static int __devinit iTCO_wdt_probe(str
  	iTCO_wdt_set_NO_REBOOT_bit();
  
  	/* The TCO logic uses the TCO_EN bit in the SMI_EN register */
 -	if (!request_region(SMI_EN, 4, "iTCO_wdt")) {
 -		pr_err("I/O address 0x%04lx already in use, device disabled\n",
 +	if (!request_region(iTCO_wdt_private.smi_res->start,
 +			resource_size(iTCO_wdt_private.smi_res), dev->name)) {
 +		pr_err("I/O address 0x%04llx already in use, device disabled\n",
- 		       SMI_EN);
+ 		       (u64)SMI_EN);
 -		ret = -EIO;
 -		goto out_unmap;
 +		ret = -EBUSY;
 +		goto unmap_gcs;
  	}
  	if (turn_SMI_watchdog_clear_off >= iTCO_wdt_private.iTCO_version) {
 -		/* Bit 13: TCO_EN -> 0 = Disables TCO logic generating an SMI# */
 +		/*
 +		 * Bit 13: TCO_EN -> 0
 +		 * Disables TCO logic generating an SMI#
 +		 */
  		val32 = inl(SMI_EN);
  		val32 &= 0xffffdfff;	/* Turn off SMI clearing watchdog */
  		outl(val32, SMI_EN);
  	}
  
 -	/* The TCO I/O registers reside in a 32-byte range pointed to
 -	   by the TCOBASE value */
 -	if (!request_region(TCOBASE, 0x20, "iTCO_wdt")) {
 -		pr_err("I/O address 0x%04lx already in use, device disabled\n",
 +	if (!request_region(iTCO_wdt_private.tco_res->start,
 +			resource_size(iTCO_wdt_private.tco_res), dev->name)) {
 +		pr_err("I/O address 0x%04llx already in use, device disabled\n",
- 		       TCOBASE);
+ 		       (u64)TCOBASE);
 -		ret = -EIO;
 -		goto unreg_smi_en;
 +		ret = -EBUSY;
 +		goto unreg_smi;
  	}
  
 -	pr_info("Found a %s TCO device (Version=%d, TCOBASE=0x%04lx)\n",
 -		iTCO_chipset_info[ent->driver_data].name,
 -		iTCO_chipset_info[ent->driver_data].iTCO_version,
 -		(u64)TCOBASE);
 +	pr_info("Found a %s TCO device (Version=%d, TCOBASE=0x%04llx)\n",
- 		ich_info->name, ich_info->iTCO_version, TCOBASE);
++		ich_info->name, ich_info->iTCO_version, (u64)TCOBASE);
  
  	/* Clear out the (probably old) status */
  	outw(0x0008, TCO1_STS);	/* Clear the Time Out Status bit */

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

             reply	other threads:[~2012-05-18  5:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-18  5:23 Stephen Rothwell [this message]
2012-05-18  8:32 ` linux-next: manual merge of the watchdog tree with the mfd tree Wim Van Sebroeck
2012-05-19  1:20   ` Guenter Roeck
2012-05-22 16:35     ` Wim Van Sebroeck
2012-05-22 22:37       ` Guenter Roeck
2012-05-22 22:46         ` Stephen Rothwell
2012-05-23  5:44         ` Wim Van Sebroeck
2012-05-23 14:26           ` Samuel Ortiz
2012-05-23 14:55             ` Wim Van Sebroeck
2013-02-08  1:52 Stephen Rothwell
2013-02-08 11:36 ` Wim Van Sebroeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120518152348.1e5070cdc16cfdf00682546d@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=asierra@xes-inc.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=rdunlap@xenotime.net \
    --cc=sameo@linux.intel.com \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.