All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: Amit Shah <amit.shah@redhat.com>,
	qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>,
	Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 0/3] Event notifications for balloon driver
Date: Tue, 22 May 2012 17:55:30 -0300	[thread overview]
Message-ID: <20120522175530.544db206@doriath.home> (raw)
In-Reply-To: <1337619593-25823-1-git-send-email-berrange@redhat.com>

On Mon, 21 May 2012 17:59:50 +0100
"Daniel P. Berrange" <berrange@redhat.com> wrote:

> This series is a followup to 2 previously posted patches
> 
>  * BALLOON_CHANGE QMP event:
>    http://lists.nongnu.org/archive/html/qemu-devel/2012-05/msg02215.html
> 
>  * query-events QMP command: 
>    http://lists.nongnu.org/archive/html/qemu-devel/2012-05/msg02255.html
> 
> Changes since v1:
> 
>  - Use a static array of strings for QMP event ID -> string conversion
>  - Add BALLOON_CHANGE to qmp-events.txt
> 
> There is also a new patch in this series, which introduces the ability
> todo simple rate limiting of stateless monitor events. With the ballooning
> of a 1.8 GB guest, down to 0.9 GB this reduced the number of events
> emitted from ~50 down to just 4, spread across a 4 second time window.

How would that be with a 1TB guest?

One way of solving this would be to move the policy to the mngt app. that is,
we could have a qmp-event-set-rate-limit command that could be allowed to
be run while in negotiation mode (ie. before qmp_capabilities is executed).

But I'm honestly not sure if rate limit is the best solution for this problem...
How can several events spread in several seconds be useful to libvirt?

IMO, the best would be to have a way to know when the balloon driver is done
servicing a balloon request.

Amit, is this possible?

  parent reply	other threads:[~2012-05-22 20:55 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-21 16:59 [Qemu-devel] [PATCH v2 0/3] Event notifications for balloon driver Daniel P. Berrange
2012-05-21 16:59 ` [Qemu-devel] [PATCH v2 1/3] Add 'query-events' command to QMP to query async events Daniel P. Berrange
2012-05-22 20:47   ` Luiz Capitulino
2012-05-21 16:59 ` [Qemu-devel] [PATCH v2 2/3] Add event notification for guest balloon changes Daniel P. Berrange
2012-05-21 19:44   ` Amit Shah
2012-05-21 19:50     ` Daniel P. Berrange
2012-05-22 12:50       ` Amit Shah
2012-05-21 16:59 ` [Qemu-devel] [PATCH v2 3/3] Add rate limiting of RTC_CHANGE, BALLOON_CHANGE & WATCHDOG events Daniel P. Berrange
     [not found]   ` <20120530155037.4e5d46df@doriath.home>
2012-06-08 16:48     ` Daniel P. Berrange
2012-06-11 17:22       ` Luiz Capitulino
2012-06-13 14:53         ` Daniel P. Berrange
2012-06-13 14:57           ` Paolo Bonzini
2012-06-13 15:06             ` Daniel P. Berrange
2012-06-13 15:35               ` Paolo Bonzini
2012-06-13 15:04     ` Daniel P. Berrange
2012-05-22 20:55 ` Luiz Capitulino [this message]
2012-05-23 10:35   ` [Qemu-devel] [PATCH v2 0/3] Event notifications for balloon driver Daniel P. Berrange
2012-05-23 14:16     ` Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120522175530.544db206@doriath.home \
    --to=lcapitulino@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.