From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36299) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXtYS-0004Jx-8N for qemu-devel@nongnu.org; Fri, 25 May 2012 08:23:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXtYN-0005L1-JM for qemu-devel@nongnu.org; Fri, 25 May 2012 08:23:39 -0400 Received: from mail-lpp01m010-f45.google.com ([209.85.215.45]:35517) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXtYN-0005KV-8x for qemu-devel@nongnu.org; Fri, 25 May 2012 08:23:35 -0400 Received: by lahc1 with SMTP id c1so722589lah.4 for ; Fri, 25 May 2012 05:23:32 -0700 (PDT) Date: Fri, 25 May 2012 14:23:28 +0200 From: "Edgar E. Iglesias" Message-ID: <20120525122328.GA9298@edde.se.axis.com> References: <1337947621-8610-1-git-send-email-peter.maydell@linaro.org> <4FBF7963.1070604@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4FBF7963.1070604@suse.de> Subject: Re: [Qemu-devel] [PATCH] qemu_find_file: check name as a straight path even if it has no '/' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: Peter Maydell , Anthony Liguori , qemu-devel@nongnu.org, patches@linaro.org On Fri, May 25, 2012 at 02:21:55PM +0200, Andreas Färber wrote: > Am 25.05.2012 14:07, schrieb Peter Maydell: > > Make qemu_find_file() check for the passed in name as a straight > > pathname even if it doesn't have any path separator character in it. > > This means that "-bios foo", "-dtb foo" etc will find a file 'foo' > > in the current directory. > > This removes an inconsistency with -kernel and -initrd, which both > > accept plain filenames as meaning files in the current directory. > > It's also less confusing for the user than an undocumented restriction > > that "this option accepts a filename, except for the special case > > where the filename you pass happens not to have a '/' in it, in > > which case we'll ignore it." > > > > Signed-off-by: Peter Maydell > > Speaking of inconsistencies, I also noticed that the ppc virtex-ml507 > machine relies on the .dtb being in the current directory with > apparently no way to override. Any chance this can be fixed, Edgar? > Maybe it can be unified with the dtb handling on ARM or share the same > QemuOpts? Yes, absolutely! Best regards, Edgar