On Thu, Jun 07, 2012 at 12:51:58AM -0700, Tony Lindgren wrote: > * Paul Walmsley [120607 00:44]: > > On Thu, 7 Jun 2012, Tony Lindgren wrote: > > > > > Here too I think driver like features like this should live in the > > > driver init for omap OHCI driver. In the likely case that FS OHCI is > > > not in use on the board, the OHCI glue can just reset it. > > > > What if the driver is not compiled into the kernel, but instead is built > > as a loadable module? > > You can still have a core piece of the driver that's always built in, such > as omap-ohci-common. But it should live under drivers, not in the bus level > code. Or you can insmod/rmmod it to reset things properly. that's such a hack... both solutions are quite hacky. The only problem here is because some bootloaders are leaving controller in an unknown state and I guess to be completely safe, resets should be done before any driver kicks in. But, driver will probably reset again the IP block during probe... -- balbi