All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] arm: Add basic support for new Marvell Armada 370 and Armada XP SoC
Date: Tue, 12 Jun 2012 13:49:27 +0000	[thread overview]
Message-ID: <201206121349.27696.arnd@arndb.de> (raw)
In-Reply-To: <1339433585-28087-1-git-send-email-gregory.clement@free-electrons.com>

On Monday 11 June 2012, Gregory CLEMENT wrote:
> You'll find in this patch set the new version of the initial support for a
> new family of ARMv7-compatible Marvell SoCs initially submitted by my
> colleague Thomas Petazzoni. Following the conclusion of the discussion when
> we submitted our first version we have chosen to add this support for this
> SoC family in the to support in the arch/arm/mach-mvebu/ directory.
> 
> As for the previous release, both the Armada 370 and the Armada XP SoCs are
> supported in this directory, and we are able to build a single kernel image
> that boots on both SoCs. Both SoCs use the PJ4B processor, a
> Marvell-developed ARM core that implements the ARMv7 instruction set. We are
> currently using Marvell evaluation boards for both of those SoCs, and the
> support for those boards is added in this patch set.

Ok, very good.

> Andrew Lunn asked for refactoring the _restart() function to being used by
> any MVEBU SOC, but we didn't find a nice way to do it. Indeed the registers
> mapping differs between the SOC and the bit mask too. A solution could be to
> get this mapping through the device tree, but we are not sure it was a good
> usage of the device tree.

As I suggested in my reply to patch 4/8, I think this can be encapsulated
in one file that acts as a driver for the generic ("bridge regs") registers
and provides functions for that based on the "compatible" property.

On a more general note, I'd prefer to have the patches renaming the existing
files first for the mach-mvebu directory first, and then adding your patches
on top.

I can provide a new version of the patch I did once we have agreement on what
goes where. I've put some more thought into it and the best I could come up
with is now.

arch/arm/mach-{orion5x,dove,kirkwood,mv78xx0}/include/mach/*
	-> arch/arm/mach-mvebu/include/mach/
arch/arm/plat-orion/include/plat/*
	-> arch/arm/mach-mvebu/include/mach/
arch/arm/plat-orion/*
	-> arch/arm/mach-mvebu/
arch/arm/mach-{orion5x,dove,kirkwood,mv78xx0}/{add-map,common,irq,mpp,pci}.*
	-> arch/arm/mach-mvebu/
arch/arm/mach-kirkwood/board-* (DT files)
	-> arch/arm/mach-mvebu/

This is basically the same as the patch I sent out before, but with the
new machine name, and leaving all the *-setup.c files in their existing
locations, where they can either get removed after being converted to DT
or after being assumed dead.

	Arnd

  parent reply	other threads:[~2012-06-12 13:49 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-11 16:52 [PATCH v2] arm: Add basic support for new Marvell Armada 370 and Armada XP SoC Gregory CLEMENT
2012-06-11 16:52 ` [PATCH v2 1/8] arm: mach-mvebu: add header Gregory CLEMENT
2012-06-11 17:11   ` Andrew Lunn
2012-06-11 16:52 ` [PATCH v2 2/8] arm: mach-mvebu: add source files Gregory CLEMENT
2012-06-12  8:45   ` Arnd Bergmann
2012-06-12 12:56     ` Gregory CLEMENT
2012-06-12 13:35       ` Arnd Bergmann
2012-06-12 15:50       ` Nicolas Pitre
2012-06-11 16:53 ` [PATCH v2 3/8] arm: mach-mvebu: add compilation/configuration change Gregory CLEMENT
2012-06-12  8:39   ` Arnd Bergmann
2012-06-12 13:01     ` Gregory CLEMENT
2012-06-11 16:53 ` [PATCH v2 4/8] arm: mach-mvebu: add support for Armada 370 and Armada XP with DT Gregory CLEMENT
2012-06-12 13:09   ` Arnd Bergmann
2012-06-11 16:53 ` [PATCH v2 5/8] arm: mach-mvebu: add documentation for new device tree bindings Gregory CLEMENT
2012-06-11 16:53 ` [PATCH v2 6/8] arm: mach-mvebu: add defconfig Gregory CLEMENT
2012-06-11 16:53 ` [PATCH v2 7/8] arm: mach-mvebu: add entry to MAINTAINERS Gregory CLEMENT
2012-06-11 16:53 ` [PATCH v2 8/8] ARM: mvebu: MPIC: read number of interrupts from control register Gregory CLEMENT
2012-06-11 20:44 ` [PATCH v2] arm: Add basic support for new Marvell Armada 370 and Armada XP SoC David Marlin
2012-06-12  7:35   ` Gregory CLEMENT
2012-06-12  8:04     ` Andrew Lunn
2012-06-12  8:09   ` Arnd Bergmann
2012-06-12 13:49 ` Arnd Bergmann [this message]
2012-06-12 13:56   ` Gregory CLEMENT
2012-06-12 14:06   ` Andrew Lunn
2012-06-12 14:24     ` Jason Cooper
2012-06-12 14:59       ` Arnd Bergmann
2012-06-12 15:40         ` Jason Cooper
2012-06-12 17:39           ` Arnd Bergmann
2012-06-13 16:14   ` Thomas Petazzoni
2012-06-13 19:19     ` Arnd Bergmann
2012-06-13 15:06 ` Jon Masters
2012-06-13 15:14   ` Gregory CLEMENT
2012-06-13 15:24   ` Arnd Bergmann
2012-06-13 15:48   ` Jason Cooper
2012-06-13 16:12     ` Arnaud Patard (Rtp)
2012-06-13 15:56   ` Nicolas Pitre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201206121349.27696.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.