From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Switch off FBC when disabling the primary plane when obscured Date: Wed, 13 Jun 2012 16:29:37 +0200 Message-ID: <20120613142937.GI4829@phenom.ffwll.local> References: <20120613104528.GF4829@phenom.ffwll.local> <1339586326-14219-1-git-send-email-chris@chris-wilson.co.uk> <20120613114024.GH4829@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-bk0-f49.google.com (mail-bk0-f49.google.com [209.85.214.49]) by gabe.freedesktop.org (Postfix) with ESMTP id E9A429E8D0 for ; Wed, 13 Jun 2012 07:28:06 -0700 (PDT) Received: by bkwj4 with SMTP id j4so590190bkw.36 for ; Wed, 13 Jun 2012 07:28:06 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20120613114024.GH4829@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Jun 13, 2012 at 01:40:24PM +0200, Daniel Vetter wrote: > On Wed, Jun 13, 2012 at 12:18:46PM +0100, Chris Wilson wrote: > > As we switch on/off the primary plane if it is completely obscured by an > > overlapping video sprite, we also nee to make sure that we update the > > FBC configuration at the same time. > > > > v2: Not all crtcs are intel_crtcs, as spotted by Daniel. > > > > References: https://bugs.freedesktop.org/show_bug.cgi?id=50238 > > Signed-off-by: Chris Wilson > > Cc: Jesse Barnes > > Reviewed-by: Jesse Barnes > > Reviewed-by: Jani Nikula > Queued for -next, thanks for the patch. Blows up on my snb, dropped again. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48