From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752851Ab2FNHQj (ORCPT ); Thu, 14 Jun 2012 03:16:39 -0400 Received: from cantor2.suse.de ([195.135.220.15]:56137 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751208Ab2FNHQi (ORCPT ); Thu, 14 Jun 2012 03:16:38 -0400 Date: Thu, 14 Jun 2012 09:16:37 +0200 From: Michal Hocko To: "Aneesh Kumar K.V" Cc: linux-mm@kvack.org, kamezawa.hiroyu@jp.fujitsu.com, dhillf@gmail.com, rientjes@google.com, akpm@linux-foundation.org, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Subject: Re: [PATCH -V9 04/15] hugetlb: use mmu_gather instead of a temporary linked list for accumulating pages Message-ID: <20120614071637.GB27397@tiehlicka.suse.cz> References: <1339583254-895-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1339583254-895-5-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <20120613145923.GA14777@tiehlicka.suse.cz> <871uljnp71.fsf@skywalker.in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <871uljnp71.fsf@skywalker.in.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 13-06-12 22:07:06, Aneesh Kumar K.V wrote: > Michal Hocko writes: > > > On Wed 13-06-12 15:57:23, Aneesh Kumar K.V wrote: > >> From: "Aneesh Kumar K.V" > >> > >> Use a mmu_gather instead of a temporary linked list for accumulating > >> pages when we unmap a hugepage range > > > > Sorry for coming up with the comment that late but you owe us an > > explanation _why_ you are doing this. > > > > I assume that this fixes a real problem when we take i_mmap_mutex > > already up in > > unmap_mapping_range > > mutex_lock(&mapping->i_mmap_mutex); > > unmap_mapping_range_tree | unmap_mapping_range_list > > unmap_mapping_range_vma > > zap_page_range_single > > unmap_single_vma > > unmap_hugepage_range > > mutex_lock(&vma->vm_file->f_mapping->i_mmap_mutex); > > > > And that this should have been marked for stable as well (I haven't > > checked when this has been introduced). > > Switch to mmu_gather is to get rid of the use of page->lru so that i can use it for > active list. So can we get this to the changelog please? -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx163.postini.com [74.125.245.163]) by kanga.kvack.org (Postfix) with SMTP id 5E6406B005C for ; Thu, 14 Jun 2012 03:16:39 -0400 (EDT) Date: Thu, 14 Jun 2012 09:16:37 +0200 From: Michal Hocko Subject: Re: [PATCH -V9 04/15] hugetlb: use mmu_gather instead of a temporary linked list for accumulating pages Message-ID: <20120614071637.GB27397@tiehlicka.suse.cz> References: <1339583254-895-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1339583254-895-5-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <20120613145923.GA14777@tiehlicka.suse.cz> <871uljnp71.fsf@skywalker.in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <871uljnp71.fsf@skywalker.in.ibm.com> Sender: owner-linux-mm@kvack.org List-ID: To: "Aneesh Kumar K.V" Cc: linux-mm@kvack.org, kamezawa.hiroyu@jp.fujitsu.com, dhillf@gmail.com, rientjes@google.com, akpm@linux-foundation.org, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org On Wed 13-06-12 22:07:06, Aneesh Kumar K.V wrote: > Michal Hocko writes: > > > On Wed 13-06-12 15:57:23, Aneesh Kumar K.V wrote: > >> From: "Aneesh Kumar K.V" > >> > >> Use a mmu_gather instead of a temporary linked list for accumulating > >> pages when we unmap a hugepage range > > > > Sorry for coming up with the comment that late but you owe us an > > explanation _why_ you are doing this. > > > > I assume that this fixes a real problem when we take i_mmap_mutex > > already up in > > unmap_mapping_range > > mutex_lock(&mapping->i_mmap_mutex); > > unmap_mapping_range_tree | unmap_mapping_range_list > > unmap_mapping_range_vma > > zap_page_range_single > > unmap_single_vma > > unmap_hugepage_range > > mutex_lock(&vma->vm_file->f_mapping->i_mmap_mutex); > > > > And that this should have been marked for stable as well (I haven't > > checked when this has been introduced). > > Switch to mmu_gather is to get rid of the use of page->lru so that i can use it for > active list. So can we get this to the changelog please? -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Hocko Subject: Re: [PATCH -V9 04/15] hugetlb: use mmu_gather instead of a temporary linked list for accumulating pages Date: Thu, 14 Jun 2012 09:16:37 +0200 Message-ID: <20120614071637.GB27397@tiehlicka.suse.cz> References: <1339583254-895-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1339583254-895-5-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <20120613145923.GA14777@tiehlicka.suse.cz> <871uljnp71.fsf@skywalker.in.ibm.com> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <871uljnp71.fsf-6yE53ggjAfyqSkle7U1LjlaTQe2KTcn/@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Aneesh Kumar K.V" Cc: linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org, dhillf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, rientjes-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Wed 13-06-12 22:07:06, Aneesh Kumar K.V wrote: > Michal Hocko writes: > > > On Wed 13-06-12 15:57:23, Aneesh Kumar K.V wrote: > >> From: "Aneesh Kumar K.V" > >> > >> Use a mmu_gather instead of a temporary linked list for accumulating > >> pages when we unmap a hugepage range > > > > Sorry for coming up with the comment that late but you owe us an > > explanation _why_ you are doing this. > > > > I assume that this fixes a real problem when we take i_mmap_mutex > > already up in > > unmap_mapping_range > > mutex_lock(&mapping->i_mmap_mutex); > > unmap_mapping_range_tree | unmap_mapping_range_list > > unmap_mapping_range_vma > > zap_page_range_single > > unmap_single_vma > > unmap_hugepage_range > > mutex_lock(&vma->vm_file->f_mapping->i_mmap_mutex); > > > > And that this should have been marked for stable as well (I haven't > > checked when this has been introduced). > > Switch to mmu_gather is to get rid of the use of page->lru so that i can use it for > active list. So can we get this to the changelog please? -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic