From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757949Ab2FOVAJ (ORCPT ); Fri, 15 Jun 2012 17:00:09 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:40514 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757812Ab2FOVAH (ORCPT ); Fri, 15 Jun 2012 17:00:07 -0400 X-Originating-IP: 217.70.178.132 X-Originating-IP: 50.43.46.74 Date: Fri, 15 Jun 2012 13:59:53 -0700 From: Josh Triplett To: "Paul E. McKenney" Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, laijs@cn.fujitsu.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca, niv@us.ibm.com, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, Valdis.Kletnieks@vt.edu, dhowells@redhat.com, eric.dumazet@gmail.com, darren@dvhart.com, fweisbec@gmail.com, patches@linaro.org Subject: Re: [PATCH tip/core/rcu 10/14] rcu: Remove function versions of __kfree_rcu and __is_kfree_rcu_offset Message-ID: <20120615205953.GN31184@leaf> References: <20120615201256.GA26120@linux.vnet.ibm.com> <1339791195-26389-1-git-send-email-paulmck@linux.vnet.ibm.com> <1339791195-26389-10-git-send-email-paulmck@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1339791195-26389-10-git-send-email-paulmck@linux.vnet.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 15, 2012 at 01:13:11PM -0700, Paul E. McKenney wrote: > From: "Paul E. McKenney" > > Commit d8169d4c (Make __kfree_rcu() less dependent on compiler choices) > added cpp macro versions of __kfree_rcu() and __is_kfree_rcu_offset(), > but failed to remove the old inline-function versions. This commit does > this cleanup. > > Signed-off-by: Paul E. McKenney Reviewed-by: Josh Triplett > include/linux/rcupdate.h | 18 ------------------ > 1 files changed, 0 insertions(+), 18 deletions(-) > > diff --git a/include/linux/rcupdate.h b/include/linux/rcupdate.h > index f773a4a..4874d26 100644 > --- a/include/linux/rcupdate.h > +++ b/include/linux/rcupdate.h > @@ -917,24 +917,6 @@ static inline notrace void rcu_read_unlock_sched_notrace(void) > #define INIT_RCU_POINTER(p, v) \ > .p = (typeof(*v) __force __rcu *)(v) > > -static __always_inline bool __is_kfree_rcu_offset(unsigned long offset) > -{ > - return offset < 4096; > -} > - > -static __always_inline > -void __kfree_rcu(struct rcu_head *head, unsigned long offset) > -{ > - typedef void (*rcu_callback)(struct rcu_head *); > - > - BUILD_BUG_ON(!__builtin_constant_p(offset)); > - > - /* See the kfree_rcu() header comment. */ > - BUILD_BUG_ON(!__is_kfree_rcu_offset(offset)); > - > - kfree_call_rcu(head, (rcu_callback)offset); > -} > - > /* > * Does the specified offset indicate that the corresponding rcu_head > * structure can be handled by kfree_rcu()? > -- > 1.7.8 >