Re: [RFC PATCH] methods to access resources of a struct pci_dev

[Ram Pai <linuxram@us.ibm.com>]

On Mon, Jun 18, 2012 at 11:30:13AM -0700, Yinghai Lu wrote:
> On Sun, Jun 17, 2012 at 10:03 PM, Ram Pai <linuxram@us.ibm.com> wrote:
> > PCI: methods to access resources of struct pci_dev
> >
> > Currently pci_dev structure holds an array of 17 PCI resources; six base
> > BARs, one ROM BAR, four BRIDGE BARs, six sriov BARs.  This is wasteful.
> > A bridge device just needs the 4 bridge resources. A non-bridge device
> > just needs the six base resources and one ROM resource. The sriov
> > resources are needed only if the device has SRIOV capability.
> >
> > The pci_dev structure needs to be re-organized to avoid unnecessary
> > bloating.  However too much code outside the pci-bus driver, assumes the
> > internal details of the pci_dev structure, thus making it hard to
> > re-organize the datastructure.
> >
> > As a first step this patch provides generic methods to access the
> > resource structure of the pci_dev.
> >
> > Once this patch is accepted, I have another 40+ patches that modify all
> > the files that directly access the resource structure, to use the new
> > methods provided in the first step.
> >
> > Finally we can re-organize the resource structure in the pci_dev
> > structure and correspondingly update the methods.
> 
> I have patchset on this, please check
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/yinghai/linux-yinghai.git
>  for-pci-for-each-res-addon
> 


Amazing, when are you pushing those patches in?  Looks like you have
patches for everything :)

Do you also have patches that change all the places that directly access
the ->resource structure?

Also does Bjorn pull regularly from your tree?  Is making patches
against your tree the right approach?

RP