Re: [patch v2] mm, oom: do not schedule if current has been killed

From: Oleg Nesterov <oleg@redhat.com>
To: David Rientjes <rientjes@google.com>
Cc: Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	linux-mm@kvack.org
Subject: Re: [patch v2] mm, oom: do not schedule if current has been killed
Date: Tue, 19 Jun 2012 15:55:51 +0200	[thread overview]
Message-ID: <20120619135551.GA24542@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1206181930550.13293@chino.kir.corp.google.com>

On 06/18, David Rientjes wrote:
>
> This patch only schedules away from current if it does not have a pending
> kill,

Can't really comment this patch, just one note...

> -	if (killed && !test_thread_flag(TIF_MEMDIE))
> +	if (killed && !fatal_signal_pending(current) &&
> +		      !(current->flags & PF_EXITING))
>  		schedule_timeout_uninterruptible(1);

Perhaps

	if (killed && !(current->flags & PF_EXITING))
		schedule_timeout_killable(1);

makes more sense?

If fatal_signal_pending() == T then schedule_timeout_killable()
is nop, but unline uninterruptible_ it can be SIGKILL'ed.

But if you prefer to check fatal_signal_pending() I won't argue.

Oleg.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>