From: Borislav Petkov <bp@amd64.org>
To: "Yu, Fenghua" <fenghua.yu@intel.com>
Cc: X86-ML <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
Andreas Herrmann <andreas.herrmann3@amd.com>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 2/2] x86, microcode: Make reload interface per system
Date: Wed, 20 Jun 2012 01:28:57 +0200 [thread overview]
Message-ID: <20120619232857.GH5996@aftab.osrc.amd.com> (raw)
In-Reply-To: <3E5A0FA7E9CA944F9D5414FEC6C7122007737623@ORSMSX105.amr.corp.intel.com>
On Tue, Jun 19, 2012 at 11:10:14PM +0000, Yu, Fenghua wrote:
> > static int __init microcode_init(void)
> > {
> > struct cpuinfo_x86 *c = &cpu_data(0);
> > @@ -559,9 +568,17 @@ static int __init microcode_init(void)
> > if (error)
> > goto out_pdev;
> >
> > + error = sysfs_create_group(&cpu_subsys.dev_root->kobj,
> > + &cpu_root_microcode_group);
> > +
> > + if (error) {
> > + pr_err("Error creating microcode group!\n");
> > + goto out_driver;
> > + }
> > +
> > error = microcode_dev_init();
> > if (error)
> > - goto out_driver;
> > + goto out_ucode_group;
> >
> If you put sysfs_create_group() after microcode_dev_init(),
> out_ucode_group is unnecessary and code is a bit simpler.
> Microcode_dev_init() doesn't rely on sysfs_create_group() and it's a
> NULL function any way.
I don't think microcode_dev_init() is a NULL function since it depends
on CONFIG_MICROCODE_OLD_INTERFACE and we have it on by default:
config MICROCODE_OLD_INTERFACE
def_bool y
depends on MICROCODE
which makes me wonder whether we still need that OLD INTERFACE.
Henrique, any thoughts here?
But you're right, reordering the registration could simplify the code.
I'll take a look at it tomorrow.
Thanks.
--
Regards/Gruss,
Boris.
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
next prev parent reply other threads:[~2012-06-19 23:29 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-19 16:03 [PATCH 0/2] x86, microcode: Reload ucode only per-system Borislav Petkov
2012-06-19 16:03 ` [PATCH 1/2] x86, microcode: Sanitize per-cpu microcode reloading interface Borislav Petkov
2012-06-19 18:25 ` Henrique de Moraes Holschuh
[not found] ` <CANDHA0iu+QtQn=UxjpN34U=Ob4ABkZc4VWpPT5EidAgZm59JJQ@mail.gmail.com>
2012-06-19 23:15 ` Yu, Fenghua
2012-06-19 23:38 ` Borislav Petkov
2012-06-19 16:03 ` [PATCH 2/2] x86, microcode: Make reload interface per system Borislav Petkov
2012-06-19 18:26 ` Henrique de Moraes Holschuh
[not found] ` <CANDHA0jf2fLOtg1E6CbyNM=omn=kj=YoRJ3VTkNA0AhkS-MLtg@mail.gmail.com>
2012-06-19 23:10 ` Yu, Fenghua
2012-06-19 23:28 ` Borislav Petkov [this message]
2012-06-20 3:26 ` Henrique de Moraes Holschuh
2012-06-20 9:57 ` Borislav Petkov
2012-06-20 23:10 ` Henrique de Moraes Holschuh
2012-06-20 8:59 ` Peter Zijlstra
2012-06-20 9:56 ` Borislav Petkov
2012-06-20 10:08 ` Peter Zijlstra
2012-06-20 10:19 ` Borislav Petkov
2012-06-20 10:22 ` Peter Zijlstra
2012-06-20 10:27 ` Borislav Petkov
2012-06-20 10:33 ` Peter Zijlstra
2012-06-20 11:09 ` Borislav Petkov
2012-06-22 18:57 ` H. Peter Anvin
2012-06-23 1:54 ` Henrique de Moraes Holschuh
2012-06-23 2:26 ` H. Peter Anvin
2012-06-20 23:21 ` Henrique de Moraes Holschuh
2012-06-20 23:26 ` Borislav Petkov
2012-06-22 16:26 ` Nix
2012-06-22 18:21 ` H. Peter Anvin
2012-06-23 1:32 ` Henrique de Moraes Holschuh
2012-06-20 23:08 ` Henrique de Moraes Holschuh
2012-06-20 23:10 ` H. Peter Anvin
2012-06-20 23:23 ` Borislav Petkov
2012-06-20 23:27 ` H. Peter Anvin
2012-06-20 23:32 ` Borislav Petkov
2012-06-20 23:34 ` H. Peter Anvin
2012-06-20 23:46 ` Borislav Petkov
2012-06-20 23:48 ` H. Peter Anvin
2012-06-21 10:07 ` Borislav Petkov
2012-06-21 23:27 ` H. Peter Anvin
2012-06-22 2:56 ` Borislav Petkov
2012-06-22 3:19 ` H. Peter Anvin
2012-06-22 3:36 ` Borislav Petkov
2012-06-22 6:41 ` Markus Trippelsdorf
2012-06-20 23:59 ` Henrique de Moraes Holschuh
2012-06-20 23:50 ` Henrique de Moraes Holschuh
2012-06-21 0:02 ` Henrique de Moraes Holschuh
2012-06-21 8:24 ` Peter Zijlstra
2012-06-21 9:58 ` Borislav Petkov
2012-06-21 23:28 ` H. Peter Anvin
2012-06-21 23:00 ` Henrique de Moraes Holschuh
2012-06-22 3:01 ` Borislav Petkov
2012-06-20 13:18 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120619232857.GH5996@aftab.osrc.amd.com \
--to=bp@amd64.org \
--cc=andreas.herrmann3@amd.com \
--cc=fenghua.yu@intel.com \
--cc=hmh@hmh.eng.br \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.