[PATCH] net: dcb: fix small regression in __dcbnl_pg_setcfg()

[PATCH] net: dcb: fix small regression in __dcbnl_pg_setcfg()

[John Fastabend]

A small regression was introduced in the reply command of
dcbnl_pg_setcfg(). User space apps may be expecting the
DCB_ATTR_PG_CFG attribute to be returned with the patch
below TX or RX variants are returned.

commit 7be994138b188387691322921c08e19bddf6d3c5
Author: Thomas Graf <tgraf@suug.ch>
Date:   Wed Jun 13 02:54:55 2012 +0000

    dcbnl: Shorten all command handling functions

This patch reverts this behavior and returns DCB_ATTR_PG_CFG

Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
---

 net/dcb/dcbnl.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/net/dcb/dcbnl.c b/net/dcb/dcbnl.c
index 0a36007..013da86 100644
--- a/net/dcb/dcbnl.c
+++ b/net/dcb/dcbnl.c
@@ -852,8 +852,7 @@ static int __dcbnl_pg_setcfg(struct net_device *netdev, struct nlmsghdr *nlh,
 		}
 	}
 
-	return nla_put_u8(skb,
-			  (dir ? DCB_CMD_PGRX_SCFG : DCB_CMD_PGTX_SCFG), 0);
+	return nla_put_u8(skb, DCB_ATTR_PG_CFG, 0);
 }
 
 static int dcbnl_pgtx_setcfg(struct net_device *netdev, struct nlmsghdr *nlh,

Re: [PATCH] net: dcb: fix small regression in __dcbnl_pg_setcfg()

[Thomas Graf]

On Wed, Jun 20, 2012 at 10:56:21PM -0700, John Fastabend wrote:
> A small regression was introduced in the reply command of
> dcbnl_pg_setcfg(). User space apps may be expecting the
> DCB_ATTR_PG_CFG attribute to be returned with the patch
> below TX or RX variants are returned.
> 
> commit 7be994138b188387691322921c08e19bddf6d3c5
> Author: Thomas Graf <tgraf@suug.ch>
> Date:   Wed Jun 13 02:54:55 2012 +0000
> 
>     dcbnl: Shorten all command handling functions
> 
> This patch reverts this behavior and returns DCB_ATTR_PG_CFG
> 
> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
> ---
> 
>  net/dcb/dcbnl.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/net/dcb/dcbnl.c b/net/dcb/dcbnl.c
> index 0a36007..013da86 100644
> --- a/net/dcb/dcbnl.c
> +++ b/net/dcb/dcbnl.c
> @@ -852,8 +852,7 @@ static int __dcbnl_pg_setcfg(struct net_device *netdev, struct nlmsghdr *nlh,
>  		}
>  	}
>  
> -	return nla_put_u8(skb,
> -			  (dir ? DCB_CMD_PGRX_SCFG : DCB_CMD_PGTX_SCFG), 0);
> +	return nla_put_u8(skb, DCB_ATTR_PG_CFG, 0);
>  }
>  

ACK

Thanks John

Re: [PATCH] net: dcb: fix small regression in __dcbnl_pg_setcfg()

[David Miller]

From: Thomas Graf <tgraf@infradead.org>
Date: Thu, 21 Jun 2012 04:19:10 -0400

> ACK

Can I get a real "Acked-by: ..." so that it automatically gets
picked up by patchwork?  Thanks.

Re: [PATCH] net: dcb: fix small regression in __dcbnl_pg_setcfg()

[Thomas Graf]

On Wed, Jun 20, 2012 at 10:56:21PM -0700, John Fastabend wrote:
> A small regression was introduced in the reply command of
> dcbnl_pg_setcfg(). User space apps may be expecting the
> DCB_ATTR_PG_CFG attribute to be returned with the patch
> below TX or RX variants are returned.
> 
> commit 7be994138b188387691322921c08e19bddf6d3c5
> Author: Thomas Graf <tgraf@suug.ch>
> Date:   Wed Jun 13 02:54:55 2012 +0000
> 
>     dcbnl: Shorten all command handling functions
> 
> This patch reverts this behavior and returns DCB_ATTR_PG_CFG
> 
> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>

Acked-by: Thomas Graf <tgraf@suug.ch>

Re: [PATCH] net: dcb: fix small regression in __dcbnl_pg_setcfg()

[David Miller]

From: Thomas Graf <tgraf@suug.ch>
Date: Thu, 21 Jun 2012 06:52:45 -0400

> On Wed, Jun 20, 2012 at 10:56:21PM -0700, John Fastabend wrote:
>> A small regression was introduced in the reply command of
>> dcbnl_pg_setcfg(). User space apps may be expecting the
>> DCB_ATTR_PG_CFG attribute to be returned with the patch
>> below TX or RX variants are returned.
>> 
>> commit 7be994138b188387691322921c08e19bddf6d3c5
>> Author: Thomas Graf <tgraf@suug.ch>
>> Date:   Wed Jun 13 02:54:55 2012 +0000
>> 
>>     dcbnl: Shorten all command handling functions
>> 
>> This patch reverts this behavior and returns DCB_ATTR_PG_CFG
>> 
>> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
> 
> Acked-by: Thomas Graf <tgraf@suug.ch>

Applied, thanks.