From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757890Ab2FYXXz (ORCPT ); Mon, 25 Jun 2012 19:23:55 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:48198 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757869Ab2FYXXx (ORCPT ); Mon, 25 Jun 2012 19:23:53 -0400 Date: Mon, 25 Jun 2012 16:23:52 -0700 From: Andrew Morton To: Glauber Costa Cc: , , , Frederic Weisbecker , David Rientjes , Pekka Enberg , Michal Hocko , Johannes Weiner , Christoph Lameter , , , Tejun Heo , Pekka Enberg , Suleiman Souhlal Subject: Re: [PATCH 09/11] memcg: propagate kmem limiting information to children Message-Id: <20120625162352.51997c5a.akpm@linux-foundation.org> In-Reply-To: <1340633728-12785-10-git-send-email-glommer@parallels.com> References: <1340633728-12785-1-git-send-email-glommer@parallels.com> <1340633728-12785-10-git-send-email-glommer@parallels.com> X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 25 Jun 2012 18:15:26 +0400 Glauber Costa wrote: > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -287,7 +287,11 @@ struct mem_cgroup { > * Should the accounting and control be hierarchical, per subtree? > */ > bool use_hierarchy; > - bool kmem_accounted; > + /* > + * bit0: accounted by this cgroup > + * bit1: accounted by a parent. > + */ > + volatile unsigned long kmem_accounted; I suggest unsigned long kmem_accounted; /* See KMEM_ACCOUNTED_*, below */ > bool oom_lock; > atomic_t under_oom; > @@ -340,6 +344,9 @@ struct mem_cgroup { > #endif > }; > > +#define KMEM_ACCOUNTED_THIS 0 > +#define KMEM_ACCOUNTED_PARENT 1 And then document the fields here. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH 09/11] memcg: propagate kmem limiting information to children Date: Mon, 25 Jun 2012 16:23:52 -0700 Message-ID: <20120625162352.51997c5a.akpm@linux-foundation.org> References: <1340633728-12785-1-git-send-email-glommer@parallels.com> <1340633728-12785-10-git-send-email-glommer@parallels.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1340633728-12785-10-git-send-email-glommer@parallels.com> Sender: owner-linux-mm@kvack.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Glauber Costa Cc: cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Frederic Weisbecker , David Rientjes , Pekka Enberg , Michal Hocko , Johannes Weiner , Christoph Lameter , devel@openvz.org, kamezawa.hiroyu@jp.fujitsu.com, Tejun Heo , Pekka Enberg , Suleiman Souhlal On Mon, 25 Jun 2012 18:15:26 +0400 Glauber Costa wrote: > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -287,7 +287,11 @@ struct mem_cgroup { > * Should the accounting and control be hierarchical, per subtree? > */ > bool use_hierarchy; > - bool kmem_accounted; > + /* > + * bit0: accounted by this cgroup > + * bit1: accounted by a parent. > + */ > + volatile unsigned long kmem_accounted; I suggest unsigned long kmem_accounted; /* See KMEM_ACCOUNTED_*, below */ > bool oom_lock; > atomic_t under_oom; > @@ -340,6 +344,9 @@ struct mem_cgroup { > #endif > }; > > +#define KMEM_ACCOUNTED_THIS 0 > +#define KMEM_ACCOUNTED_PARENT 1 And then document the fields here. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org