From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753712Ab2FYRon (ORCPT ); Mon, 25 Jun 2012 13:44:43 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:41387 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752113Ab2FYRom (ORCPT ); Mon, 25 Jun 2012 13:44:42 -0400 Date: Mon, 25 Jun 2012 10:44:37 -0700 From: Tejun Heo To: Glauber Costa Cc: cgroups@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, Frederic Weisbecker , David Rientjes , Pekka Enberg , Michal Hocko , Johannes Weiner , Christoph Lameter , devel@openvz.org, kamezawa.hiroyu@jp.fujitsu.com, Suleiman Souhlal Subject: Re: [PATCH 01/11] memcg: Make it possible to use the stock for more than one page. Message-ID: <20120625174437.GC3869@google.com> References: <1340633728-12785-1-git-send-email-glommer@parallels.com> <1340633728-12785-2-git-send-email-glommer@parallels.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1340633728-12785-2-git-send-email-glommer@parallels.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey, Glauber. Just a couple nits. On Mon, Jun 25, 2012 at 06:15:18PM +0400, Glauber Costa wrote: > From: Suleiman Souhlal It would be nice to explain why this is being done. Just a simple statement like - "prepare for XXX" or "will be needed by XXX". > /* > - * Try to consume stocked charge on this cpu. If success, one page is consumed > - * from local stock and true is returned. If the stock is 0 or charges from a > - * cgroup which is not current target, returns false. This stock will be > - * refilled. > + * Try to consume stocked charge on this cpu. If success, nr_pages pages are > + * consumed from local stock and true is returned. If the stock is 0 or > + * charges from a cgroup which is not current target, returns false. > + * This stock will be refilled. I hope this were converted to proper /** function comment with arguments and return value description. Thanks. -- tejun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx116.postini.com [74.125.245.116]) by kanga.kvack.org (Postfix) with SMTP id 023106B01F7 for ; Mon, 25 Jun 2012 13:44:42 -0400 (EDT) Received: by dakp5 with SMTP id p5so6939804dak.14 for ; Mon, 25 Jun 2012 10:44:42 -0700 (PDT) Date: Mon, 25 Jun 2012 10:44:37 -0700 From: Tejun Heo Subject: Re: [PATCH 01/11] memcg: Make it possible to use the stock for more than one page. Message-ID: <20120625174437.GC3869@google.com> References: <1340633728-12785-1-git-send-email-glommer@parallels.com> <1340633728-12785-2-git-send-email-glommer@parallels.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1340633728-12785-2-git-send-email-glommer@parallels.com> Sender: owner-linux-mm@kvack.org List-ID: To: Glauber Costa Cc: cgroups@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, Frederic Weisbecker , David Rientjes , Pekka Enberg , Michal Hocko , Johannes Weiner , Christoph Lameter , devel@openvz.org, kamezawa.hiroyu@jp.fujitsu.com, Suleiman Souhlal Hey, Glauber. Just a couple nits. On Mon, Jun 25, 2012 at 06:15:18PM +0400, Glauber Costa wrote: > From: Suleiman Souhlal It would be nice to explain why this is being done. Just a simple statement like - "prepare for XXX" or "will be needed by XXX". > /* > - * Try to consume stocked charge on this cpu. If success, one page is consumed > - * from local stock and true is returned. If the stock is 0 or charges from a > - * cgroup which is not current target, returns false. This stock will be > - * refilled. > + * Try to consume stocked charge on this cpu. If success, nr_pages pages are > + * consumed from local stock and true is returned. If the stock is 0 or > + * charges from a cgroup which is not current target, returns false. > + * This stock will be refilled. I hope this were converted to proper /** function comment with arguments and return value description. Thanks. -- tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 01/11] memcg: Make it possible to use the stock for more than one page. Date: Mon, 25 Jun 2012 10:44:37 -0700 Message-ID: <20120625174437.GC3869@google.com> References: <1340633728-12785-1-git-send-email-glommer@parallels.com> <1340633728-12785-2-git-send-email-glommer@parallels.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=x/yTqJBfEOUJrlQVFZbj8Ye7V0qyhjxOxhypwFryDw4=; b=KBzm3VGM+jkezraAoR+AMtAAx2i1elg0Z/TwlXmx3uZEeLcI+bu9IwmYX0ZUI2J38O Ch3/BcG/NHPCANPfQrrc9FFV29Jv9kGgROUtF+xAswX2E0m7oXNyYV6Z5RxVNlYTAg7U z7TxKcCEIdpRYbta8baeGbpnkUC22EQHhVqGZsomMdmPZbINYAVrj2hrAjlaRPKkMNCc 3firKtntY8mXz/QNPX7HXhEqzchBcPOk4iKclPX9juzGwrSnQTA84ckRmnFmhzi7S6Yk 1Eb+WPRYqcPa4K/KJMMwqx1BjEx8hisCWoiuLHz90EILX7t79vGKfTpgQDdyahvoGdnu AH/g== Content-Disposition: inline In-Reply-To: <1340633728-12785-2-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Glauber Costa Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, Andrew Morton , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Frederic Weisbecker , David Rientjes , Pekka Enberg , Michal Hocko , Johannes Weiner , Christoph Lameter , devel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org, kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org, Suleiman Souhlal Hey, Glauber. Just a couple nits. On Mon, Jun 25, 2012 at 06:15:18PM +0400, Glauber Costa wrote: > From: Suleiman Souhlal It would be nice to explain why this is being done. Just a simple statement like - "prepare for XXX" or "will be needed by XXX". > /* > - * Try to consume stocked charge on this cpu. If success, one page is consumed > - * from local stock and true is returned. If the stock is 0 or charges from a > - * cgroup which is not current target, returns false. This stock will be > - * refilled. > + * Try to consume stocked charge on this cpu. If success, nr_pages pages are > + * consumed from local stock and true is returned. If the stock is 0 or > + * charges from a cgroup which is not current target, returns false. > + * This stock will be refilled. I hope this were converted to proper /** function comment with arguments and return value description. Thanks. -- tejun