From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754798Ab2FZXbv (ORCPT ); Tue, 26 Jun 2012 19:31:51 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:37041 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754446Ab2FZXbu (ORCPT ); Tue, 26 Jun 2012 19:31:50 -0400 Date: Tue, 26 Jun 2012 16:31:47 -0700 From: Andrew Morton To: Akinobu Mita Cc: linux-kernel@vger.kernel.org, Pavel Machek , "Rafael J. Wysocki" , linux-pm@lists.linux-foundation.org, Greg KH , linux-mm@kvack.org, Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, =?ISO-8859-1?Q?Am=E9rico?= Wang Subject: Re: [PATCH -v4 6/6] fault-injection: add notifier error injection testing scripts Message-Id: <20120626163147.93181e21.akpm@linux-foundation.org> In-Reply-To: <1340463502-15341-7-git-send-email-akinobu.mita@gmail.com> References: <1340463502-15341-1-git-send-email-akinobu.mita@gmail.com> <1340463502-15341-7-git-send-email-akinobu.mita@gmail.com> X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 23 Jun 2012 23:58:22 +0900 Akinobu Mita wrote: > This adds two testing scripts with notifier error injection Can we move these into tools/testing/selftests/, so that a "make run_tests" runs these tests? Also, I don't think it's appropriate that "fault-injection" be in the path - that's an implementation detail. What we're testing here is memory hotplug, pm, cpu hotplug, etc. So each test would go into, say, tools/testing/selftests/cpu-hotplug. Now, your cpu-hotplug test only tests a tiny part of the cpu-hotplug code. But it is a start, and creates the place where additional tests will be placed in the future. If the kernel configuration means that the tests cannot be run, the attempt should succeed so that other tests are not disrupted. I guess that printing a warning in this case is useful. Probably the selftests will require root permissions - we haven't really thought about that much. If these tests require root (I assume they do?) then a sensible approach would be to check for that and to emit a warning and return "success". My overall take on the fault-injection code is that there has been a disappointing amount of uptake: I don't see many developers using them for whitebox testing their stuff. I guess this patchset addresses that, in a way. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH -v4 6/6] fault-injection: add notifier error injection testing scripts Date: Tue, 26 Jun 2012 16:31:47 -0700 Message-ID: <20120626163147.93181e21.akpm@linux-foundation.org> References: <1340463502-15341-1-git-send-email-akinobu.mita@gmail.com> <1340463502-15341-7-git-send-email-akinobu.mita@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1340463502-15341-7-git-send-email-akinobu.mita@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: Akinobu Mita Cc: Greg KH , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Paul Mackerras , =?ISO-8859-1?Q?Am=E9rico?= Wang , linux-pm@lists.linux-foundation.org, linuxppc-dev@lists.ozlabs.org List-Id: linux-pm@vger.kernel.org On Sat, 23 Jun 2012 23:58:22 +0900 Akinobu Mita wrote: > This adds two testing scripts with notifier error injection Can we move these into tools/testing/selftests/, so that a "make run_tests" runs these tests? Also, I don't think it's appropriate that "fault-injection" be in the path - that's an implementation detail. What we're testing here is memory hotplug, pm, cpu hotplug, etc. So each test would go into, say, tools/testing/selftests/cpu-hotplug. Now, your cpu-hotplug test only tests a tiny part of the cpu-hotplug code. But it is a start, and creates the place where additional tests will be placed in the future. If the kernel configuration means that the tests cannot be run, the attempt should succeed so that other tests are not disrupted. I guess that printing a warning in this case is useful. Probably the selftests will require root permissions - we haven't really thought about that much. If these tests require root (I assume they do?) then a sensible approach would be to check for that and to emit a warning and return "success". My overall take on the fault-injection code is that there has been a disappointing amount of uptake: I don't see many developers using them for whitebox testing their stuff. I guess this patchset addresses that, in a way. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx167.postini.com [74.125.245.167]) by kanga.kvack.org (Postfix) with SMTP id 8862D6B004D for ; Tue, 26 Jun 2012 19:31:50 -0400 (EDT) Date: Tue, 26 Jun 2012 16:31:47 -0700 From: Andrew Morton Subject: Re: [PATCH -v4 6/6] fault-injection: add notifier error injection testing scripts Message-Id: <20120626163147.93181e21.akpm@linux-foundation.org> In-Reply-To: <1340463502-15341-7-git-send-email-akinobu.mita@gmail.com> References: <1340463502-15341-1-git-send-email-akinobu.mita@gmail.com> <1340463502-15341-7-git-send-email-akinobu.mita@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Akinobu Mita Cc: linux-kernel@vger.kernel.org, Pavel Machek , "Rafael J. Wysocki" , linux-pm@lists.linux-foundation.org, Greg KH , linux-mm@kvack.org, Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, =?ISO-8859-1?Q?Am=E9rico?= Wang On Sat, 23 Jun 2012 23:58:22 +0900 Akinobu Mita wrote: > This adds two testing scripts with notifier error injection Can we move these into tools/testing/selftests/, so that a "make run_tests" runs these tests? Also, I don't think it's appropriate that "fault-injection" be in the path - that's an implementation detail. What we're testing here is memory hotplug, pm, cpu hotplug, etc. So each test would go into, say, tools/testing/selftests/cpu-hotplug. Now, your cpu-hotplug test only tests a tiny part of the cpu-hotplug code. But it is a start, and creates the place where additional tests will be placed in the future. If the kernel configuration means that the tests cannot be run, the attempt should succeed so that other tests are not disrupted. I guess that printing a warning in this case is useful. Probably the selftests will require root permissions - we haven't really thought about that much. If these tests require root (I assume they do?) then a sensible approach would be to check for that and to emit a warning and return "success". My overall take on the fault-injection code is that there has been a disappointing amount of uptake: I don't see many developers using them for whitebox testing their stuff. I guess this patchset addresses that, in a way. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) by ozlabs.org (Postfix) with ESMTP id 6DE0CB6F13 for ; Wed, 27 Jun 2012 09:31:50 +1000 (EST) Date: Tue, 26 Jun 2012 16:31:47 -0700 From: Andrew Morton To: Akinobu Mita Subject: Re: [PATCH -v4 6/6] fault-injection: add notifier error injection testing scripts Message-Id: <20120626163147.93181e21.akpm@linux-foundation.org> In-Reply-To: <1340463502-15341-7-git-send-email-akinobu.mita@gmail.com> References: <1340463502-15341-1-git-send-email-akinobu.mita@gmail.com> <1340463502-15341-7-git-send-email-akinobu.mita@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Cc: Greg KH , linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , linux-mm@kvack.org, Paul Mackerras , Pavel Machek , =?ISO-8859-1?Q?Am=E9rico?= Wang , linux-pm@lists.linux-foundation.org, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sat, 23 Jun 2012 23:58:22 +0900 Akinobu Mita wrote: > This adds two testing scripts with notifier error injection Can we move these into tools/testing/selftests/, so that a "make run_tests" runs these tests? Also, I don't think it's appropriate that "fault-injection" be in the path - that's an implementation detail. What we're testing here is memory hotplug, pm, cpu hotplug, etc. So each test would go into, say, tools/testing/selftests/cpu-hotplug. Now, your cpu-hotplug test only tests a tiny part of the cpu-hotplug code. But it is a start, and creates the place where additional tests will be placed in the future. If the kernel configuration means that the tests cannot be run, the attempt should succeed so that other tests are not disrupted. I guess that printing a warning in this case is useful. Probably the selftests will require root permissions - we haven't really thought about that much. If these tests require root (I assume they do?) then a sensible approach would be to check for that and to emit a warning and return "success". My overall take on the fault-injection code is that there has been a disappointing amount of uptake: I don't see many developers using them for whitebox testing their stuff. I guess this patchset addresses that, in a way.