All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gavin Shan <shangw@linux.vnet.ibm.com>
To: Dave Hansen <dave@linux.vnet.ibm.com>
Cc: Gavin Shan <shangw@linux.vnet.ibm.com>,
	linux-mm@kvack.org, rientjes@google.com, hannes@cmpxchg.org,
	akpm@linux-foundation.org
Subject: Re: [PATCH 4/5] mm/sparse: more check on mem_section number
Date: Wed, 27 Jun 2012 08:29:15 +0800	[thread overview]
Message-ID: <20120627002915.GA4066@shangw> (raw)
In-Reply-To: <4FE9E028.7010006@linux.vnet.ibm.com>

>> --- a/mm/sparse.c
>> +++ b/mm/sparse.c
>> @@ -160,6 +160,8 @@ int __section_nr(struct mem_section* ms)
>>  		     break;
>>  	}
>> 
>> +	VM_BUG_ON(root_nr == NR_SECTION_ROOTS);
>> +
>>  	return (root_nr * SECTIONS_PER_ROOT) + (ms - root);
>>  }
>
>If you're going to bother with a VM_BUG_ON(), I'd probably make it:
>
>	VM_BUG_ON(root_nr >= NR_SECTION_ROOTS);

Thanks, I'll change it according to your suggestion in next revision.

Thanks,
Gavin

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2012-06-27  0:29 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-23 15:52 [PATCH 1/5] mm/sparse: check size of struct mm_section Gavin Shan
2012-06-23 15:52 ` [PATCH 2/5] mm/sparse: optimize sparse_index_alloc Gavin Shan
2012-06-25 15:30   ` Michal Hocko
2012-06-26  6:07     ` Gavin Shan
2012-06-26  7:04       ` Michal Hocko
2012-06-26  7:13         ` Gavin Shan
2012-06-23 15:52 ` [PATCH 3/5] mm/sparse: fix possible memory leak Gavin Shan
2012-06-25 15:48   ` Michal Hocko
2012-06-26  6:11     ` Gavin Shan
2012-06-26  7:14       ` Michal Hocko
2012-06-26  7:17         ` Gavin Shan
2012-06-23 15:52 ` [PATCH 4/5] mm/sparse: more check on mem_section number Gavin Shan
2012-06-26 16:15   ` Dave Hansen
2012-06-27  0:29     ` Gavin Shan [this message]
2012-06-23 15:52 ` [PATCH 5/5] mm/sparse: return 0 if root mem_section exists Gavin Shan
2012-06-24 19:18   ` KOSAKI Motohiro
2012-06-25  1:09     ` Gavin Shan
2012-06-25 15:39   ` Michal Hocko
2012-06-25 16:03 ` [PATCH 1/5] mm/sparse: check size of struct mm_section Michal Hocko
2012-06-25 16:35   ` Gavin Shan
2012-06-26  7:39     ` Michal Hocko
2012-06-26  7:48       ` Gavin Shan
2012-06-26  8:06         ` Michal Hocko
2012-06-26  8:24           ` Gavin Shan
2012-06-26 17:57             ` Michal Hocko
2012-06-27  3:01               ` Gavin Shan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120627002915.GA4066@shangw \
    --to=shangw@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=dave@linux.vnet.ibm.com \
    --cc=hannes@cmpxchg.org \
    --cc=linux-mm@kvack.org \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.