From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756233Ab2F0JEk (ORCPT ); Wed, 27 Jun 2012 05:04:40 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]:33694 "EHLO acsinet15.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752460Ab2F0JEi (ORCPT ); Wed, 27 Jun 2012 05:04:38 -0400 Date: Wed, 27 Jun 2012 12:04:29 +0300 From: Dan Carpenter To: Anil Ravindranath Cc: "James E.J. Bottomley" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch 2/3 -resend] [SCSI] pmcraid: cpu_to_le32() => cpu_to_le64() Message-ID: <20120627090428.GK31212@elgon.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120627085800.GA3007@mwanda> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet21.oracle.com [156.151.31.93] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The cpu_to_le32() truncates the address to 32 bits. All the other places that set .address use cpu_to_le64(). Signed-off-by: Dan Carpenter --- What about if dma_addr_t is 32 bits on a big endian system? Can that happen? This patch was originally sent on Fri, 16 Dec 2011 and I sent a second reminder on Mon, Apr 30, 2012. I was silently ignored both times. diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c index d81a159..a38dade 100644 --- a/drivers/scsi/pmcraid.c +++ b/drivers/scsi/pmcraid.c @@ -1242,7 +1242,7 @@ static struct pmcraid_cmd *pmcraid_init_hcam ioadl[0].flags |= IOADL_FLAGS_READ_LAST; ioadl[0].data_len = cpu_to_le32(rcb_size); - ioadl[0].address = cpu_to_le32(dma); + ioadl[0].address = cpu_to_le64(dma); cmd->cmd_done = cmd_done; return cmd; From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Wed, 27 Jun 2012 09:04:29 +0000 Subject: [patch 2/3 -resend] [SCSI] pmcraid: cpu_to_le32() => cpu_to_le64() Message-Id: <20120627090428.GK31212@elgon.mountain> List-Id: References: <20120627085800.GA3007@mwanda> In-Reply-To: <20120627085800.GA3007@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Anil Ravindranath Cc: "James E.J. Bottomley" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org The cpu_to_le32() truncates the address to 32 bits. All the other places that set .address use cpu_to_le64(). Signed-off-by: Dan Carpenter --- What about if dma_addr_t is 32 bits on a big endian system? Can that happen? This patch was originally sent on Fri, 16 Dec 2011 and I sent a second reminder on Mon, Apr 30, 2012. I was silently ignored both times. diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c index d81a159..a38dade 100644 --- a/drivers/scsi/pmcraid.c +++ b/drivers/scsi/pmcraid.c @@ -1242,7 +1242,7 @@ static struct pmcraid_cmd *pmcraid_init_hcam ioadl[0].flags |= IOADL_FLAGS_READ_LAST; ioadl[0].data_len = cpu_to_le32(rcb_size); - ioadl[0].address = cpu_to_le32(dma); + ioadl[0].address = cpu_to_le64(dma); cmd->cmd_done = cmd_done; return cmd;