From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757312Ab2F0MiO (ORCPT ); Wed, 27 Jun 2012 08:38:14 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]:23547 "EHLO acsinet15.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753616Ab2F0MiL (ORCPT ); Wed, 27 Jun 2012 08:38:11 -0400 Date: Wed, 27 Jun 2012 15:37:34 +0300 From: Dan Carpenter To: Alex Williamson Cc: Stephen Rothwell , Linus Torvalds , Andrew Morton , Greg Kroah-Hartman , linux-kernel , kvm , linux-pci , iommu , qemu-devel , Benjamin Herrenschmidt , Alexey Kardashevskiy , David Gibson , chrisw , "Roedel, Joerg" , linux-next@vger.kernel.org Subject: Re: Request VFIO inclusion in linux-next Message-ID: <20120627123733.GA5449@mwanda> References: <1340686552.1207.128.camel@bling.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1340686552.1207.128.camel@bling.home> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet22.oracle.com [156.151.31.94] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 25, 2012 at 10:55:52PM -0600, Alex Williamson wrote: > Hi, > > VFIO has been kicking around for well over a year now and has been > posted numerous times for review. The pre-requirements are finally > available in linux-next (or will be in the 20120626 build) so I'd like > to request a new branch be included in linux-next with a goal of being > accepted into v3.6. > Could you run Sparse over the driver? http://lwn.net/Articles/205624/ It reports a bunch of endian problems. Some are definitely bugs like: *prev |= cpu_to_le32((u32)epos << 20); regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: Request VFIO inclusion in linux-next Date: Wed, 27 Jun 2012 15:37:34 +0300 Message-ID: <20120627123733.GA5449@mwanda> References: <1340686552.1207.128.camel@bling.home> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1340686552.1207.128.camel-xdHQ/5r00wBBDLzU/O5InQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Alex Williamson Cc: Stephen Rothwell , Benjamin Herrenschmidt , kvm , Alexey Kardashevskiy , Greg Kroah-Hartman , linux-kernel , qemu-devel , chrisw , iommu , linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pci , Andrew Morton , Linus Torvalds , David Gibson List-Id: linux-next.vger.kernel.org On Mon, Jun 25, 2012 at 10:55:52PM -0600, Alex Williamson wrote: > Hi, > > VFIO has been kicking around for well over a year now and has been > posted numerous times for review. The pre-requirements are finally > available in linux-next (or will be in the 20120626 build) so I'd like > to request a new branch be included in linux-next with a goal of being > accepted into v3.6. > Could you run Sparse over the driver? http://lwn.net/Articles/205624/ It reports a bunch of endian problems. Some are definitely bugs like: *prev |= cpu_to_le32((u32)epos << 20); regards, dan carpenter