From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: greg@kroah.com, linux-serial@vger.kernel.org
Subject: Re: [PATCH 06/12] 8250: use the 8250 register interface not the legacy one
Date: Wed, 27 Jun 2012 23:50:49 +0100 [thread overview]
Message-ID: <20120627235049.36aeb659@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <CAP=VYLopNPeYCi4uQoHuqU0vWFF5hc4J9x3uzSOXJVv=DGLLWw@mail.gmail.com>
On Wed, 27 Jun 2012 18:39:53 -0400
Paul Gortmaker <paul.gortmaker@windriver.com> wrote:
> On Wed, Jun 27, 2012 at 7:22 AM, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> > From: Alan Cox <alan@linux.intel.com>
> >
> > The old interface just copies bits over and calls the newer one.
> > In addition we can now pass more information.
> >
> > Signed-off-by: Alan Cox <alan@linux.intel.com>
> > ---
>
> [...]
>
> > - * serial8250_register_port and serial8250_unregister_port allows for
> > + * serial8250_register_8250_port and serial8250_unregister_port allows
>
> This seems a bit lopsided. Can we convert the unregister too, and
> then just keep the old names, and avoid the doubling up on the
> presence of 8250 in the name? (I confess to having not looked
> at the code to seeing if there is an obvious barrier to doing this),
That wouldn't be a bad idea for a follow up. I didn't pick the names -
they were changed earlier so that we could have both APIs. Now the old
API is gone we could at some point rename it back - but that ought to
wait a while so any out of tree stuff continues to break for a bit to
avoid accidents.
Alan
next prev parent reply other threads:[~2012-06-27 22:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 11:21 [PATCH 01/12] f81232: correct stubbed termios handler Alan Cox
2012-06-27 11:21 ` [PATCH 02/12] usb: fix sillies in the metro USB driver Alan Cox
2012-06-27 11:21 ` [PATCH 03/12] tty: Note n_tty race Alan Cox
2012-06-27 11:21 ` [PATCH 04/12] gpio-sch: Fix leak of resource Alan Cox
2012-06-27 19:32 ` Greg KH
2012-06-27 11:21 ` [PATCH 05/12] usb, kobil: Sort out some bogus tty handling Alan Cox
2012-06-27 11:22 ` [PATCH 06/12] 8250: use the 8250 register interface not the legacy one Alan Cox
2012-06-27 22:39 ` Paul Gortmaker
2012-06-27 22:50 ` Alan Cox [this message]
2012-06-27 11:22 ` [PATCH 07/12] 8250: propogate the bugs field Alan Cox
2012-06-27 11:22 ` [PATCH 08/12] 8250: add support for ASIX devices with a FIFO bug Alan Cox
2012-06-27 11:22 ` [PATCH 10/12] tty: tidy up the RESET_TERMIOS case Alan Cox
2012-06-27 11:23 ` [PATCH 11/12] vt: fix the keyboard/led locking Alan Cox
2012-06-27 11:23 ` [PATCH 12/12] tty: Move the handling of the tty release logic Alan Cox
2012-06-27 19:35 ` [PATCH 01/12] f81232: correct stubbed termios handler Greg KH
-- strict thread matches above, loose matches on Subject: below --
2012-07-14 14:30 [PATCH 00/12] tty: take 3 - termios, locking and 8250 bugs Alan Cox
2012-07-14 14:33 ` [PATCH 06/12] 8250: use the 8250 register interface not the legacy one Alan Cox
2012-07-16 20:09 ` Greg KH
2012-07-16 20:29 ` Alan Cox
2012-07-16 21:29 ` Greg KH
2012-06-22 15:36 [PATCH 01/12] f81232: correct stubbed termios handler Alan Cox
2012-06-22 15:43 ` [PATCH 06/12] 8250: use the 8250 register interface not the legacy one Alan Cox
2012-06-27 2:30 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120627235049.36aeb659@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=greg@kroah.com \
--cc=linux-serial@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.