From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Thu, 28 Jun 2012 00:48:14 +0200 Subject: [U-Boot] [PATCH v4 3/6] mcx: Disable DCACHE since USB EHCI is enabled In-Reply-To: <4FEB890D.3010801@emcraft.com> References: <1340209283-3404-1-git-send-email-trini@ti.com> <1340230468-12811-4-git-send-email-trini@ti.com> <4FEB890D.3010801@emcraft.com> Message-ID: <201206280048.15039.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Ilya Yanok, > Hi, > > 21.06.2012 02:14, Tom Rini wrote: > > USB EHCI and DCACHE are not compatible, so disable DCACHE support at > > build-time as run-time disable is insufficient for USB use. > > Sorry for missing this discussion. I think compile-time disabling of the > cache is too brutal. > ehci-hcd cache handling is broken anyway: doing unaligned > flushes/invalidates is a bug, and we know for sure that upper layers > don't care about alignment (and I bet ehci-hcd does this even for its > internal buffers). So what's the point in all this cache handling in > ehci-hcd? It's not going to work anyway and just produces problems. So I > suggest to just disable all this stuff until generic code will be fixed. > Alternatively we can do bounce-buffering inside driver. We should rather introduce generic bounce buffer. But the upper layers are getting fixed recently so we should be getting there. > > Regards, Ilya. Best regards, Marek Vasut