From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [PATCH v2 2/2] net: flexcan: add transceiver switch gpios support Date: Thu, 28 Jun 2012 20:05:24 +0800 Message-ID: <20120628120522.GH22990@S2101-09.ap.freescale.net> References: <1340853701-4488-1-git-send-email-shawn.guo@linaro.org> <1340853701-4488-3-git-send-email-shawn.guo@linaro.org> <4FEC329C.7070004@pengutronix.de> <20120628112111.GC22990@S2101-09.ap.freescale.net> <4FEC400F.8010506@pengutronix.de> <20120628114108.GD22990@S2101-09.ap.freescale.net> <20120628115224.GF22990@S2101-09.ap.freescale.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Received: from va3ehsobe005.messaging.microsoft.com ([216.32.180.31]:20119 "EHLO va3outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751833Ab2F1MFI (ORCPT ); Thu, 28 Jun 2012 08:05:08 -0400 Content-Disposition: inline In-Reply-To: <20120628115224.GF22990@S2101-09.ap.freescale.net> Sender: linux-can-owner@vger.kernel.org List-ID: To: Marc Kleine-Budde Cc: Hui Wang , "David S. Miller" , linux-arm-kernel@lists.infradead.org, linux-can@vger.kernel.org On Thu, Jun 28, 2012 at 07:52:26PM +0800, Shawn Guo wrote: > Do you care the variable name also? If so, we will get: > > int transceiver_en_gpio; > int transceiver_stby_gpio; > bool transceiver_en_high; > bool transceiver_stby_high; > > So everything becomes long :) > Oh, even longer, since we have agreed "high" should be renamed to "active_low": bool transceiver_en_active_low; bool transceiver_stby_active_low; Can we keep using "phy" to have the names a little bit shorter? -- Regards, Shawn From mboxrd@z Thu Jan 1 00:00:00 1970 From: shawn.guo@linaro.org (Shawn Guo) Date: Thu, 28 Jun 2012 20:05:24 +0800 Subject: [PATCH v2 2/2] net: flexcan: add transceiver switch gpios support In-Reply-To: <20120628115224.GF22990@S2101-09.ap.freescale.net> References: <1340853701-4488-1-git-send-email-shawn.guo@linaro.org> <1340853701-4488-3-git-send-email-shawn.guo@linaro.org> <4FEC329C.7070004@pengutronix.de> <20120628112111.GC22990@S2101-09.ap.freescale.net> <4FEC400F.8010506@pengutronix.de> <20120628114108.GD22990@S2101-09.ap.freescale.net> <20120628115224.GF22990@S2101-09.ap.freescale.net> Message-ID: <20120628120522.GH22990@S2101-09.ap.freescale.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Jun 28, 2012 at 07:52:26PM +0800, Shawn Guo wrote: > Do you care the variable name also? If so, we will get: > > int transceiver_en_gpio; > int transceiver_stby_gpio; > bool transceiver_en_high; > bool transceiver_stby_high; > > So everything becomes long :) > Oh, even longer, since we have agreed "high" should be renamed to "active_low": bool transceiver_en_active_low; bool transceiver_stby_active_low; Can we keep using "phy" to have the names a little bit shorter? -- Regards, Shawn