linux-next: build warning after merge of the hid tree

linux-next: build warning after merge of the hid tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]

Hi Jiri,

After merging the hid tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

drivers/hid/Kconfig:7:error: recursive dependency detected!
drivers/hid/Kconfig:7:	symbol HID is selected by USB_HID
drivers/hid/usbhid/Kconfig:4:	symbol USB_HID depends on HID

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build warning after merge of the hid tree

[Jiri Kosina]

On Mon, 2 Jul 2012, Stephen Rothwell wrote:

> Hi Jiri,
> 
> After merging the hid tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
> 
> drivers/hid/Kconfig:7:error: recursive dependency detected!
> drivers/hid/Kconfig:7:	symbol HID is selected by USB_HID
> drivers/hid/usbhid/Kconfig:4:	symbol USB_HID depends on HID

This is fixed in for-next branch I have just pushed. Thanks,

-- 
Jiri Kosina
SUSE Labs

Re: linux-next: build warning after merge of the hid tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2003 bytes --]

Hi Bastien,

On Tue, 04 Apr 2023 11:18:35 +0200 Bastien Nocera <hadess@hadess.net> wrote:
>
> Before I send patches, does this look correct to you?
> 
> diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c
> index 7930dca84616..7c7f88ca4f62 100644
> --- a/drivers/usb/core/message.c
> +++ b/drivers/usb/core/message.c
> @@ -1926,7 +1926,7 @@ static void __usb_wireless_status_intf(struct work_struct *ws)
> 1926⋮1926│ 
> 1927⋮1927│ /**
> 1928⋮1928│  * usb_set_wireless_status - sets the wireless_status struct member
> 1929⋮    │- * @dev: the device to modify
>     ⋮1929│+ * @iface: the interface to modify
> 1930⋮1930│  * @status: the new wireless status
> 1931⋮1931│  *
> 1932⋮1932│  * Set the wireless_status struct member to the new value, and emit

That looks good.

> diff --git a/include/linux/usb.h b/include/linux/usb.h
> index a48eeec62a66..3d523ebf0c09 100644
> --- a/include/linux/usb.h
> +++ b/include/linux/usb.h
> @@ -261,7 +261,8 @@ struct usb_interface {
>  261⋮ 261│      unsigned needs_binding:1;       /* needs delayed unbind/rebind */
>  262⋮ 262│      unsigned resetting_device:1;    /* true: bandwidth alloc after reset */
>  263⋮ 263│      unsigned authorized:1;          /* used for interface authorization */
>  264⋮    │-     enum usb_wireless_status wireless_status;
>     ⋮ 264│+     enum usb_wireless_status wireless_status; /* whether the emitter is
>     ⋮ 265│+                                                * connected to this receiver */
>  265⋮ 266│      struct work_struct wireless_status_work;
>  266⋮ 267│ 
>  267⋮ 268│      struct device dev;              /* interface specific device info */
> 

This is not right, though.  The warning was about
"wireless_status_work" not "wireless_status", so I think you need a
description of wireless_status_work in the block comment above the
struct definition.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the hid tree

[Bastien Nocera]

On Tue, 2023-04-04 at 18:55 +1000, Stephen Rothwell wrote:
> Hi Bastien,
> 
> On Tue, 04 Apr 2023 10:22:35 +0200 Bastien Nocera <hadess@hadess.net>
> wrote:
> > 
> > On Tue, 2023-04-04 at 15:42 +1000, Stephen Rothwell wrote:
> > > 
> > > On Tue, 4 Apr 2023 15:40:05 +1000 Stephen Rothwell
> > > <sfr@canb.auug.org.au> wrote:  
> > > > 
> > > > After merging the hid tree, today's linux-next build (htmldocs)
> > > > produced
> > > > this warning:
> > > > 
> > > > drivers/usb/core/message.c:1939: warning: Function parameter or
> > > > member 'iface' not described in 'usb_set_wireless_status'
> > > > drivers/usb/core/message.c:1939: warning: Excess function
> > > > parameter
> > > > 'dev' description in 'usb_set_wireless_status'
> > > > 
> > > > Introduced by commit
> > > > 
> > > >   0a4db185f078 ("USB: core: Add API to change the
> > > > wireless_status")  
> > > 
> > > Also this:
> > > 
> > > include/linux/usb.h:270: warning: Function parameter or member
> > > 'wireless_status_work' not described in 'usb_interface'
> > 
> > How does one reproduce those warnings?
> 
> I just ran "make htmldocs" (see above).  You may need to install some
> software - but it will tell you if so.
> 

Before I send patches, does this look correct to you?

diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c
index 7930dca84616..7c7f88ca4f62 100644
--- a/drivers/usb/core/message.c
+++ b/drivers/usb/core/message.c
@@ -1926,7 +1926,7 @@ static void __usb_wireless_status_intf(struct work_struct *ws)
1926⋮1926│ 
1927⋮1927│ /**
1928⋮1928│  * usb_set_wireless_status - sets the wireless_status struct member
1929⋮    │- * @dev: the device to modify
    ⋮1929│+ * @iface: the interface to modify
1930⋮1930│  * @status: the new wireless status
1931⋮1931│  *
1932⋮1932│  * Set the wireless_status struct member to the new value, and emit
diff --git a/include/linux/usb.h b/include/linux/usb.h
index a48eeec62a66..3d523ebf0c09 100644
--- a/include/linux/usb.h
+++ b/include/linux/usb.h
@@ -261,7 +261,8 @@ struct usb_interface {
 261⋮ 261│      unsigned needs_binding:1;       /* needs delayed unbind/rebind */
 262⋮ 262│      unsigned resetting_device:1;    /* true: bandwidth alloc after reset */
 263⋮ 263│      unsigned authorized:1;          /* used for interface authorization */
 264⋮    │-     enum usb_wireless_status wireless_status;
    ⋮ 264│+     enum usb_wireless_status wireless_status; /* whether the emitter is
    ⋮ 265│+                                                * connected to this receiver */
 265⋮ 266│      struct work_struct wireless_status_work;
 266⋮ 267│ 
 267⋮ 268│      struct device dev;              /* interface specific device info */

Re: linux-next: build warning after merge of the hid tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1118 bytes --]

Hi Bastien,

On Tue, 04 Apr 2023 10:22:35 +0200 Bastien Nocera <hadess@hadess.net> wrote:
>
> On Tue, 2023-04-04 at 15:42 +1000, Stephen Rothwell wrote:
> > 
> > On Tue, 4 Apr 2023 15:40:05 +1000 Stephen Rothwell
> > <sfr@canb.auug.org.au> wrote:  
> > > 
> > > After merging the hid tree, today's linux-next build (htmldocs)
> > > produced
> > > this warning:
> > > 
> > > drivers/usb/core/message.c:1939: warning: Function parameter or
> > > member 'iface' not described in 'usb_set_wireless_status'
> > > drivers/usb/core/message.c:1939: warning: Excess function parameter
> > > 'dev' description in 'usb_set_wireless_status'
> > > 
> > > Introduced by commit
> > > 
> > >   0a4db185f078 ("USB: core: Add API to change the wireless_status")  
> > 
> > Also this:
> > 
> > include/linux/usb.h:270: warning: Function parameter or member
> > 'wireless_status_work' not described in 'usb_interface'
> 
> How does one reproduce those warnings?

I just ran "make htmldocs" (see above).  You may need to install some
software - but it will tell you if so.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the hid tree

[Bastien Nocera]

On Tue, 2023-04-04 at 15:42 +1000, Stephen Rothwell wrote:
> Hi all,
> 
> On Tue, 4 Apr 2023 15:40:05 +1000 Stephen Rothwell
> <sfr@canb.auug.org.au> wrote:
> > 
> > After merging the hid tree, today's linux-next build (htmldocs)
> > produced
> > this warning:
> > 
> > drivers/usb/core/message.c:1939: warning: Function parameter or
> > member 'iface' not described in 'usb_set_wireless_status'
> > drivers/usb/core/message.c:1939: warning: Excess function parameter
> > 'dev' description in 'usb_set_wireless_status'
> > 
> > Introduced by commit
> > 
> >   0a4db185f078 ("USB: core: Add API to change the wireless_status")
> 
> Also this:
> 
> include/linux/usb.h:270: warning: Function parameter or member
> 'wireless_status_work' not described in 'usb_interface'
> 

How does one reproduce those warnings?

Re: linux-next: build warning after merge of the hid tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 709 bytes --]

Hi all,

On Tue, 4 Apr 2023 15:40:05 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the hid tree, today's linux-next build (htmldocs) produced
> this warning:
> 
> drivers/usb/core/message.c:1939: warning: Function parameter or member 'iface' not described in 'usb_set_wireless_status'
> drivers/usb/core/message.c:1939: warning: Excess function parameter 'dev' description in 'usb_set_wireless_status'
> 
> Introduced by commit
> 
>   0a4db185f078 ("USB: core: Add API to change the wireless_status")

Also this:

include/linux/usb.h:270: warning: Function parameter or member 'wireless_status_work' not described in 'usb_interface'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the hid tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 470 bytes --]

Hi all,

After merging the hid tree, today's linux-next build (htmldocs) produced
this warning:

drivers/usb/core/message.c:1939: warning: Function parameter or member 'iface' not described in 'usb_set_wireless_status'
drivers/usb/core/message.c:1939: warning: Excess function parameter 'dev' description in 'usb_set_wireless_status'

Introduced by commit

  0a4db185f078 ("USB: core: Add API to change the wireless_status")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the hid tree

[Jiri Kosina]

On Wed, 10 Nov 2021, Stephen Rothwell wrote:

> Hi all,
> 
> After merging the hid tree, today's linux-next build (htmldocs) produced
> this warning:
> 
> include/linux/mod_devicetable.h:909: warning: Function parameter or member 'guid' not described in 'ishtp_device_id'
> 
> Introduced by commit
> 
>   fa443bc3c1e4 ("HID: intel-ish-hid: add support for MODULE_DEVICE_TABLE()")
> 
> I also notice that there is a @context description, but no field.

Thanks for spotting it. The kerneldoc is clearly wrong there both on the 
'guid' member name, and also the description (mind the '36 char' part, 
where it should have been '16 char' instead).

Thomas, could you please send me a fixup patch for that?

Thanks,

-- 
Jiri Kosina
SUSE Labs

linux-next: build warning after merge of the hid tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 427 bytes --]

Hi all,

After merging the hid tree, today's linux-next build (htmldocs) produced
this warning:

include/linux/mod_devicetable.h:909: warning: Function parameter or member 'guid' not described in 'ishtp_device_id'

Introduced by commit

  fa443bc3c1e4 ("HID: intel-ish-hid: add support for MODULE_DEVICE_TABLE()")

I also notice that there is a @context description, but no field.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the hid tree

[Jiri Kosina]

On Mon, 30 Apr 2012, Stephen Rothwell wrote:

> Hi Jiri,
> 
> After merging the hid tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> In file included from drivers/hid/hid-core.c:37:0:
> include/linux/hidraw.h: In function 'hidraw_report_event':
> include/linux/hidraw.h:85:46: warning: no return statement in function returning non-void [-Wreturn-type]
> 
> Introduced by commit b6787242f327 ("HID: hidraw: add proper error
> handling to raw event reporting").

Now fixed by d6d7c87352, thanks a lot for the report.

-- 
Jiri Kosina
SUSE Labs

linux-next: build warning after merge of the hid tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 514 bytes --]

Hi Jiri,

After merging the hid tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

In file included from drivers/hid/hid-core.c:37:0:
include/linux/hidraw.h: In function 'hidraw_report_event':
include/linux/hidraw.h:85:46: warning: no return statement in function returning non-void [-Wreturn-type]

Introduced by commit b6787242f327 ("HID: hidraw: add proper error
handling to raw event reporting").
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build warning after merge of the hid tree

[Jiri Kosina]

On Thu, 29 Mar 2012, Stephen Rothwell wrote:

> After merging the hid tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
> 
> drivers/hid/Kconfig:595:error: recursive dependency detected!
> drivers/hid/Kconfig:595:	symbol HID_WACOM depends on HID_WACOM
> 
> Caused (very obviously) by commit 224b321b312e ("HID: wacom: Remove
> CONFIG_HID_WACOM_POWER_SUPPLY option").

Yeah, it has been already fixed in my tree a few hours after the first 
commit, but I raced with you snapshotting the tree. It should be gone now.

> Please test this stuff.  And don't rush stuff in during the merge window ...

Hm, I accidentally pushed it out to for-next, even though it's not 
destined for current merge window. Will flush the for-next branch now, 
sorry for that. I don't have anything pending for this merge window at the 
moment, so the for-next queue definitely should be empty.

Thanks,

-- 
Jiri Kosina
SUSE Labs

linux-next: build warning after merge of the hid tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 505 bytes --]

Hi Jiri,

After merging the hid tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

drivers/hid/Kconfig:595:error: recursive dependency detected!
drivers/hid/Kconfig:595:	symbol HID_WACOM depends on HID_WACOM

Caused (very obviously) by commit 224b321b312e ("HID: wacom: Remove
CONFIG_HID_WACOM_POWER_SUPPLY option").

Please test this stuff.  And don't rush stuff in during the merge window ...
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]