From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q630T0bX030520 for ; Mon, 2 Jul 2012 19:29:00 -0500 Received: from ipmail06.adl2.internode.on.net (ipmail06.adl2.internode.on.net [150.101.137.129]) by cuda.sgi.com with ESMTP id x858NabdElyq02RH for ; Mon, 02 Jul 2012 17:28:58 -0700 (PDT) Date: Tue, 3 Jul 2012 10:28:57 +1000 From: Dave Chinner Subject: Re: [PATCH 2/2] xfs: do not call xfs_bdstrat_cb in xfs_buf_iodone_callbacks Message-ID: <20120703002857.GY19223@dastard> References: <20120702100003.960640484@bombadil.infradead.org> <20120702100034.921366796@bombadil.infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120702100034.921366796@bombadil.infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com On Mon, Jul 02, 2012 at 06:00:05AM -0400, Christoph Hellwig wrote: > xfs_bdstrat_cb only adds a check for a shutdown filesystem over xfs_buf_iorequest, > but xfs_buf_iodone_callbacks just checked for a shut down filesystem a little > earlier. In addition the shutdown handling in xfs_bdstrat_cb is not very suitable > for this caller. Makes sense - I have a patch locally that does this as part of a xfs_buf_iorequest(bp, blkno, length) conversion to get rid of XFS_BUF_SETADDR().... > Signed-off-by: Christoph Hellwig Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs