From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 08/10] drm/i915: introduce
 haswell_init_clock_gating
Date: Wed, 4 Jul 2012 09:27:58 +0200
Message-ID: <20120704072758.GA5375@phenom.ffwll.local>
References: <1341240671-5843-1-git-send-email-eugeni.dodonov@intel.com>
	<1341240671-5843-9-git-send-email-eugeni.dodonov@intel.com>
	<20120703202418.GE5103@phenom.ffwll.local>
	<4FF38844.6050707@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com
	[209.85.212.171])
	by gabe.freedesktop.org (Postfix) with ESMTP id 5D866A09A0
	for <intel-gfx@lists.freedesktop.org>;
	Wed,  4 Jul 2012 00:28:05 -0700 (PDT)
Received: by wibhq4 with SMTP id hq4so3693527wib.12
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 04 Jul 2012 00:28:04 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <4FF38844.6050707@linux.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: eugeni.dodonov@intel.com
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Jul 03, 2012 at 09:03:16PM -0300, Eugeni Dodonov wrote:
> On 07/03/12 17:24, Daniel Vetter wrote:
> > On Mon, Jul 02, 2012 at 11:51:09AM -0300, Eugeni Dodonov wrote:
> >> This is based on Ivy Bridge clock gating for now, but is subject to
> >> changes in the future.
> >>
> >> Signed-off-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
> > 
> > This copy of presumeably the ivb clock gate code is missing the changes
> > introduce in:
> > 
> > commit 208482232de3590cee4757dfabe5d8cee8c6e626
> > Author: Ben Widawsky <ben@bwidawsk.net>
> > Date:   Fri May 4 18:58:59 2012 -0700
> > 
> >     drm/i915: set IDICOS to medium uncore resources
> > 
> > I guess that's not quite intentional ...
> > 
> > All the previous patches up to here are queued for -next, thanks.
> 
> I thought that this one was specific for Ivy Bridge, so I just skipped it...
> 
> I have not tried setting these settings on Haswell, so I don't know if
> it is useful here as well. I'll try later this week to see if there are
> any visible effects.

Ok, I've merged the patch and took a note that you volunteered for some
benchmarking. But the commit message really should have mentioned why this
was dropped compared to the ivb clock gating function it was copy&pasted
from. I've added a note to that effect.
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48