All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] xfs: do not call xfs_bdstrat_cb in xfs_buf_iodone_callbacks
Date: Wed, 4 Jul 2012 11:16:50 -0400	[thread overview]
Message-ID: <20120704151650.GB25762@infradead.org> (raw)
In-Reply-To: <20120704083234.GG19223@dastard>

On Wed, Jul 04, 2012 at 06:32:34PM +1000, Dave Chinner wrote:
> IMO, using uncached buffers in transactions is dangerous because
> concurrent transactions can't find buffers uncached buffers at the
> same address and so such buffers need higher level synchronisation
> interfaces (as the superblock has).
> 
> I'm happy to leave the superblock as uncached and work around it in
> some way, but it just seems wrong to me to have one buffer behaves
> differently to all the cached and other uncached buffers in the
> system. It doesn't sit well in my mind to do that when the problem
> simply goes away if we make the superblock a cached buffer again....

The superblock buffer always has been more special than others, remember
the old FS_MANAGED flag before we went for uncached buffers?

If you want to move it back to normal buffers how do you want to look
it up, given that IIRC we read it before setting up the perag buffers.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2012-07-04 15:16 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-02 10:00 [PATCH 0/2] buffer caches fixes for Linux 3.5 Christoph Hellwig
2012-07-02 10:00 ` [PATCH 1/2] xfs: prevent recursion in xfs_buf_iorequest Christoph Hellwig
2012-07-03  0:27   ` Dave Chinner
2012-07-02 10:00 ` [PATCH 2/2] xfs: do not call xfs_bdstrat_cb in xfs_buf_iodone_callbacks Christoph Hellwig
2012-07-03  0:28   ` Dave Chinner
2012-07-03 16:05     ` Christoph Hellwig
2012-07-03 23:29       ` Dave Chinner
2012-07-04  5:57         ` Christoph Hellwig
2012-07-04  8:32           ` Dave Chinner
2012-07-04 15:16             ` Christoph Hellwig [this message]
2012-07-12 23:04   ` Ben Myers
2012-07-13  6:16     ` Christoph Hellwig
2012-07-13  6:24       ` [PATCH 2/2 v2] " Christoph Hellwig
2012-07-13 16:59         ` Ben Myers
2012-07-13 19:12         ` Ben Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120704151650.GB25762@infradead.org \
    --to=hch@infradead.org \
    --cc=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.