From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Wed, 04 Jul 2012 22:19:12 +0200 Subject: [U-Boot] [RESEND 11/11] snowball: Adding board specific cache cleanup routine In-Reply-To: <4FF49F2C.1030301@linaro.org> References: <1341413915-7944-1-git-send-email-mathieu.poirier@linaro.org> <1341413915-7944-12-git-send-email-mathieu.poirier@linaro.org> <20120704185319.B55572026BF@gemini.denx.de> <4FF49F2C.1030301@linaro.org> Message-ID: <20120704201912.7D1DD2026BF@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Mathieu, In message <4FF49F2C.1030301@linaro.org> you wrote: > > >> + *((volatile unsigned int *)(0xA0412900)) = 0xFF; > >> + *((volatile unsigned int *)(0xA0412904)) = 0xFF; > > > > NAK. Please use proper I/O accessors, and declare a C struct to > > access these registers. > > Ok, to make sure I do this properly please point me to an example in the > code base where I can find I/O accessors. > > Also, could you be more specific about the C struct you're like to see > implemented - again and example in the code would be welcomed. See arch/arm/include/asm/io.h for the respective I/O accessors. As I have no idea which registers might be hidden by these magig numbers 0xA0412900 or 0xA0412904 it's hard for me to find any good example. See for example accesses like the writel(val, &ccm->cgr0); in arch/arm/cpu/arm926ejs/mx25/generic.c, etc. etc. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Remember, there's a big difference between kneeling down and bending over. - Frank Zappa