From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47708) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SmWwd-00048E-7M for qemu-devel@nongnu.org; Wed, 04 Jul 2012 17:17:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SmWwa-0008Vj-Ew for qemu-devel@nongnu.org; Wed, 04 Jul 2012 17:17:06 -0400 Date: Thu, 5 Jul 2012 00:17:17 +0300 From: "Michael S. Tsirkin" Message-ID: <20120704211717.GC27653@redhat.com> References: <1341422373-13614-1-git-send-email-afaerber@suse.de> <1341422373-13614-15-git-send-email-afaerber@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1341422373-13614-15-git-send-email-afaerber@suse.de> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 14/14] pci: Tidy up PCI host bridges List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: jbaron@redhat.com, qemu-devel@nongnu.org, Alexander Graf , Andreas =?iso-8859-1?Q?F=E4rber?= , "open list:New World" , anthony@codemonkey.ws, pbonzini@redhat.com On Wed, Jul 04, 2012 at 07:19:33PM +0200, Andreas F=E4rber wrote: > Uglify the parent field to enforce QOM-style access via casts. > Don't just typedef PCIHostState, either use it directly or embed it. >=20 > Signed-off-by: Andreas F=E4rber > --- > hw/alpha_typhoon.c | 4 ++-- > hw/dec_pci.c | 2 +- > hw/grackle_pci.c | 2 +- > hw/gt64xxx.c | 26 ++++++++++++++++---------- > hw/piix_pci.c | 6 ++++-- > hw/ppc4xx_pci.c | 8 +++++--- > hw/ppce500_pci.c | 2 +- > hw/prep_pci.c | 8 +++++--- > hw/spapr_pci.c | 12 +++++++----- > hw/spapr_pci.h | 2 +- > hw/unin_pci.c | 14 +++++++------- > 11 files changed, 50 insertions(+), 36 deletions(-) >=20 > diff --git a/hw/alpha_typhoon.c b/hw/alpha_typhoon.c > index 58025a3..955d628 100644 > --- a/hw/alpha_typhoon.c > +++ b/hw/alpha_typhoon.c > @@ -46,7 +46,7 @@ typedef struct TyphoonPchip { > OBJECT_CHECK(TyphoonState, (obj), TYPE_TYPHOON_PCI_HOST_BRIDGE) > =20 > typedef struct TyphoonState { > - PCIHostState host; > + PCIHostState parent_obj; > =20 > TyphoonCchip cchip; > TyphoonPchip pchip; > @@ -770,7 +770,7 @@ PCIBus *typhoon_init(ram_addr_t ram_size, ISABus **= isa_bus, > b =3D pci_register_bus(dev, "pci", > typhoon_set_irq, sys_map_irq, s, > &s->pchip.reg_mem, addr_space_io, 0, 64); > - s->host.bus =3D b; > + PCI_HOST_BRIDGE(s)->bus =3D b; > =20 > /* Pchip0 PCI special/interrupt acknowledge, 0x801.F800.0000, 64MB= . */ > memory_region_init_io(&s->pchip.reg_iack, &alpha_pci_iack_ops, b, Sorry I don't understand. why are we making code ugly apparently intentionally? > diff --git a/hw/dec_pci.c b/hw/dec_pci.c > index de16361..c30ade3 100644 > --- a/hw/dec_pci.c > +++ b/hw/dec_pci.c > @@ -43,7 +43,7 @@ > #define DEC_21154(obj) OBJECT_CHECK(DECState, (obj), TYPE_DEC_21154) > =20 > typedef struct DECState { > - PCIHostState host_state; > + PCIHostState parent_obj; > } DECState; > =20 > static int dec_map_irq(PCIDevice *pci_dev, int irq_num) > diff --git a/hw/grackle_pci.c b/hw/grackle_pci.c > index 066f6e1..67da307 100644 > --- a/hw/grackle_pci.c > +++ b/hw/grackle_pci.c > @@ -41,7 +41,7 @@ > OBJECT_CHECK(GrackleState, (obj), TYPE_GRACKLE_PCI_HOST_BRIDGE) > =20 > typedef struct GrackleState { > - PCIHostState host_state; > + PCIHostState parent_obj; > =20 > MemoryRegion pci_mmio; > MemoryRegion pci_hole; > diff --git a/hw/gt64xxx.c b/hw/gt64xxx.c > index 857758e..e95e664 100644 > --- a/hw/gt64xxx.c > +++ b/hw/gt64xxx.c > @@ -235,7 +235,7 @@ > OBJECT_CHECK(GT64120State, (obj), TYPE_GT64120_PCI_HOST_BRIDGE) > =20 > typedef struct GT64120State { > - PCIHostState pci; > + PCIHostState parent_obj; > =20 > uint32_t regs[GT_REGS]; > PCI_MAPPING_ENTRY(PCI0IO); > @@ -315,6 +315,7 @@ static void gt64120_writel (void *opaque, target_ph= ys_addr_t addr, > uint64_t val, unsigned size) > { > GT64120State *s =3D opaque; > + PCIHostState *phb =3D PCI_HOST_BRIDGE(s); > uint32_t saddr; > =20 > if (!(s->regs[GT_CPU] & 0x00001000)) > @@ -535,13 +536,15 @@ static void gt64120_writel (void *opaque, target_= phys_addr_t addr, > /* not implemented */ > break; > case GT_PCI0_CFGADDR: > - s->pci.config_reg =3D val & 0x80fffffc; > + phb->config_reg =3D val & 0x80fffffc; > break; > case GT_PCI0_CFGDATA: > - if (!(s->regs[GT_PCI0_CMD] & 1) && (s->pci.config_reg & 0x00ff= f800)) > + if (!(s->regs[GT_PCI0_CMD] & 1) && (phb->config_reg & 0x00fff8= 00)) { > val =3D bswap32(val); > - if (s->pci.config_reg & (1u << 31)) > - pci_data_write(s->pci.bus, s->pci.config_reg, val, 4); > + } > + if (phb->config_reg & (1u << 31)) { > + pci_data_write(phb->bus, phb->config_reg, val, 4); > + } > break; > =20 > /* Interrupts */ > @@ -594,6 +597,7 @@ static uint64_t gt64120_readl (void *opaque, > target_phys_addr_t addr, unsigned size) > { > GT64120State *s =3D opaque; > + PCIHostState *phb =3D PCI_HOST_BRIDGE(s); > uint32_t val; > uint32_t saddr; > =20 > @@ -775,15 +779,17 @@ static uint64_t gt64120_readl (void *opaque, > =20 > /* PCI Internal */ > case GT_PCI0_CFGADDR: > - val =3D s->pci.config_reg; > + val =3D phb->config_reg; > break; > case GT_PCI0_CFGDATA: > - if (!(s->pci.config_reg & (1 << 31))) > + if (!(phb->config_reg & (1 << 31))) { > val =3D 0xffffffff; > - else > - val =3D pci_data_read(s->pci.bus, s->pci.config_reg, 4); > - if (!(s->regs[GT_PCI0_CMD] & 1) && (s->pci.config_reg & 0x00ff= f800)) > + } else { > + val =3D pci_data_read(phb->bus, phb->config_reg, 4); > + } > + if (!(s->regs[GT_PCI0_CMD] & 1) && (phb->config_reg & 0x00fff8= 00)) { > val =3D bswap32(val); > + } > break; > =20 > case GT_PCI0_CMD: > diff --git a/hw/piix_pci.c b/hw/piix_pci.c > index 0523d81..9522a27 100644 > --- a/hw/piix_pci.c > +++ b/hw/piix_pci.c > @@ -36,7 +36,9 @@ > * http://download.intel.com/design/chipsets/datashts/29054901.pdf > */ > =20 > -typedef PCIHostState I440FXState; > +typedef struct I440FXState { > + PCIHostState parent_obj; > +} I440FXState; > =20 > #define PIIX_NUM_PIC_IRQS 16 /* i8259 * 2 */ > #define PIIX_NUM_PIRQS 4ULL /* PIRQ[A-D] */ > @@ -273,7 +275,7 @@ static PCIBus *i440fx_common_init(const char *devic= e_name, > dev =3D qdev_create(NULL, "i440FX-pcihost"); > s =3D PCI_HOST_BRIDGE(dev); > s->address_space =3D address_space_mem; > - b =3D pci_bus_new(&s->busdev.qdev, NULL, pci_address_space, > + b =3D pci_bus_new(dev, NULL, pci_address_space, > address_space_io, 0); > s->bus =3D b; > object_property_add_child(qdev_get_machine(), "i440fx", OBJECT(dev= ), NULL); > diff --git a/hw/ppc4xx_pci.c b/hw/ppc4xx_pci.c > index 5583321..a14fd42 100644 > --- a/hw/ppc4xx_pci.c > +++ b/hw/ppc4xx_pci.c > @@ -52,7 +52,7 @@ struct PCITargetMap { > #define PPC4xx_PCI_NR_PTMS 2 > =20 > struct PPC4xxPCIState { > - PCIHostState pci_state; > + PCIHostState parent_obj; > =20 > struct PCIMasterMap pmm[PPC4xx_PCI_NR_PMMS]; > struct PCITargetMap ptm[PPC4xx_PCI_NR_PTMS]; > @@ -96,16 +96,18 @@ static uint64_t pci4xx_cfgaddr_read(void *opaque, t= arget_phys_addr_t addr, > unsigned size) > { > PPC4xxPCIState *ppc4xx_pci =3D opaque; > + PCIHostState *phb =3D PCI_HOST_BRIDGE(ppc4xx_pci); > =20 > - return ppc4xx_pci->pci_state.config_reg; > + return phb->config_reg; > } > =20 > static void pci4xx_cfgaddr_write(void *opaque, target_phys_addr_t addr= , > uint64_t value, unsigned size) > { > PPC4xxPCIState *ppc4xx_pci =3D opaque; > + PCIHostState *phb =3D PCI_HOST_BRIDGE(ppc4xx_pci); > =20 > - ppc4xx_pci->pci_state.config_reg =3D value & ~0x3; > + phb->config_reg =3D value & ~0x3; > } > =20 > static const MemoryRegionOps pci4xx_cfgaddr_ops =3D { > diff --git a/hw/ppce500_pci.c b/hw/ppce500_pci.c > index 3333967..92b1dc0 100644 > --- a/hw/ppce500_pci.c > +++ b/hw/ppce500_pci.c > @@ -78,7 +78,7 @@ struct pci_inbound { > OBJECT_CHECK(PPCE500PCIState, (obj), TYPE_PPC_E500_PCI_HOST_BRIDGE= ) > =20 > struct PPCE500PCIState { > - PCIHostState pci_state; > + PCIHostState parent_obj; > =20 > struct pci_outbound pob[PPCE500_PCI_NR_POBS]; > struct pci_inbound pib[PPCE500_PCI_NR_PIBS]; > diff --git a/hw/prep_pci.c b/hw/prep_pci.c > index 35cb9b2..cc44e61 100644 > --- a/hw/prep_pci.c > +++ b/hw/prep_pci.c > @@ -34,7 +34,7 @@ > OBJECT_CHECK(PREPPCIState, (obj), TYPE_RAVEN_PCI_HOST_BRIDGE) > =20 > typedef struct PRePPCIState { > - PCIHostState host_state; > + PCIHostState parent_obj; > =20 > MemoryRegion intack; > qemu_irq irq[4]; > @@ -60,14 +60,16 @@ static void ppc_pci_io_write(void *opaque, target_p= hys_addr_t addr, > uint64_t val, unsigned int size) > { > PREPPCIState *s =3D opaque; > - pci_data_write(s->host_state.bus, PPC_PCIIO_config(addr), val, siz= e); > + PCIHostState *phb =3D PCI_HOST_BRIDGE(s); > + pci_data_write(phb->bus, PPC_PCIIO_config(addr), val, size); > } > =20 > static uint64_t ppc_pci_io_read(void *opaque, target_phys_addr_t addr, > unsigned int size) > { > PREPPCIState *s =3D opaque; > - return pci_data_read(s->host_state.bus, PPC_PCIIO_config(addr), si= ze); > + PCIHostState *phb =3D PCI_HOST_BRIDGE(s); > + return pci_data_read(phb->bus, PPC_PCIIO_config(addr), size); > } > =20 > static const MemoryRegionOps PPC_PCIIO_ops =3D { > diff --git a/hw/spapr_pci.c b/hw/spapr_pci.c > index 7d84801..9231e0e 100644 > --- a/hw/spapr_pci.c > +++ b/hw/spapr_pci.c > @@ -36,16 +36,18 @@ static PCIDevice *find_dev(sPAPREnvironment *spapr, > uint64_t buid, uint32_t config_addr) > { > int devfn =3D (config_addr >> 8) & 0xFF; > - sPAPRPHBState *phb; > + sPAPRPHBState *sphb; > =20 > - QLIST_FOREACH(phb, &spapr->phbs, list) { > + QLIST_FOREACH(sphb, &spapr->phbs, list) { > + PCIHostState *phb; > BusChild *kid; > =20 > - if (phb->buid !=3D buid) { > + if (sphb->buid !=3D buid) { > continue; > } > =20 > - QTAILQ_FOREACH(kid, &phb->host_state.bus->qbus.children, sibli= ng) { > + phb =3D PCI_HOST_BRIDGE(sphb); > + QTAILQ_FOREACH(kid, &BUS(phb->bus)->children, sibling) { > PCIDevice *dev =3D (PCIDevice *)kid->child; > if (dev->devfn =3D=3D devfn) { > return dev; > @@ -319,7 +321,7 @@ static int spapr_phb_init(SysBusDevice *s) > pci_spapr_set_irq, pci_spapr_map_irq, phb, > &phb->memspace, &phb->iospace, > PCI_DEVFN(0, 0), PCI_NUM_PINS); > - phb->host_state.bus =3D bus; > + PCI_HOST_BRIDGE(phb)->bus =3D bus; > =20 > liobn =3D SPAPR_PCI_BASE_LIOBN | (pci_find_domain(bus) << 16); > phb->dma =3D spapr_tce_new_dma_context(liobn, 0x40000000); > diff --git a/hw/spapr_pci.h b/hw/spapr_pci.h > index 06e2742..6840814 100644 > --- a/hw/spapr_pci.h > +++ b/hw/spapr_pci.h > @@ -33,7 +33,7 @@ > OBJECT_CHECK(sPAPRPHBState, (obj), TYPE_SPAPR_PCI_HOST_BRIDGE) > =20 > typedef struct sPAPRPHBState { > - PCIHostState host_state; > + PCIHostState parent_obj; > =20 > uint64_t buid; > char *busname; > diff --git a/hw/unin_pci.c b/hw/unin_pci.c > index 0db7c1f..d3aaa5a 100644 > --- a/hw/unin_pci.c > +++ b/hw/unin_pci.c > @@ -53,7 +53,7 @@ static const int unin_irq_line[] =3D { 0x1b, 0x1c, 0x= 1d, 0x1e }; > OBJECT_CHECK(UNINState, (obj), TYPE_U3_AGP_HOST_BRIDGE) > =20 > typedef struct UNINState { > - PCIHostState host_state; > + PCIHostState parent_obj; > =20 > MemoryRegion pci_mmio; > MemoryRegion pci_hole; > @@ -114,22 +114,22 @@ static uint32_t unin_get_config_reg(uint32_t reg,= uint32_t addr) > static void unin_data_write(void *opaque, target_phys_addr_t addr, > uint64_t val, unsigned len) > { > - UNINState *s =3D opaque; > + PCIHostState *phb =3D PCI_HOST_BRIDGE(opaque); > UNIN_DPRINTF("write addr %" TARGET_FMT_plx " len %d val %"PRIx64"\= n", > addr, len, val); > - pci_data_write(s->host_state.bus, > - unin_get_config_reg(s->host_state.config_reg, addr)= , > + pci_data_write(phb->bus, > + unin_get_config_reg(phb->config_reg, addr), > val, len); > } > =20 > static uint64_t unin_data_read(void *opaque, target_phys_addr_t addr, > unsigned len) > { > - UNINState *s =3D opaque; > + PCIHostState *phb =3D PCI_HOST_BRIDGE(opaque); > uint32_t val; > =20 > - val =3D pci_data_read(s->host_state.bus, > - unin_get_config_reg(s->host_state.config_reg, = addr), > + val =3D pci_data_read(phb->bus, > + unin_get_config_reg(phb->config_reg, addr), > len); > UNIN_DPRINTF("read addr %" TARGET_FMT_plx " len %d val %x\n", > addr, len, val); > --=20 > 1.7.7