All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Christian Kujau <lists@nerdbynature.de>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: 3.5.0-rc5: inconsistent lock state
Date: Fri, 6 Jul 2012 11:01:26 +1000	[thread overview]
Message-ID: <20120706010126.GT19223@dastard> (raw)
In-Reply-To: <alpine.DEB.2.01.1207051615421.5568@trent.utfs.org>

On Thu, Jul 05, 2012 at 04:39:21PM -0700, Christian Kujau wrote:
> On Fri, 6 Jul 2012 at 07:59, Dave Chinner wrote:
> > It means that you have enough attributes that they don't fit in the
> > inode, so every time they are read or written you have to do an
> > extra IO on top of reading/writing the inode. Performance can easily
> > drop by an order of magnitude when the attributes are moved out of
> > the inode....
> 
> xfs_info shows isize=256 - but I'm not sure how I would have exceeded that 
> limit? I'm not using SELinux or anhy other security frameworks on that 
> machine, only plain unix permissions. Just check again, no ACLs, no EAs, 
> no file attributes are set on these filesystems.

Applications can use attributes without you being aware of them.
e.g. Samba, desktop search/indexing, etc might be using attributes
even though you aren't explicitly using them....

> The filesystems make heavy use of hardlinks, but files usually have no
> more than ~12 hardlinks, so that counter should not exceed the inode
> size either.

Hardlinks are not attributes, and the counter is in the inode core
so this won't have any impact on attributes being places out of
line.

> > Typically there is 50-70 bytes of attribute space available in 256
> > byte inodes, larger attributes or lots of them will push them out of
> > the inode....
> 
> 50 bytes sounds more than enought for holding only unix permissions.

Unix permissions are held in the inode core, not in the attribute
space.

And i did say "typically". if you have a file that has 6-7 extents,
then there won't be any space for attributes and it will put new
attributes out of line immediately....

> Does 
> it matter that the filesystem is somewhat larger? Not too large though, 
> all xfs filesystems are < 1TB in size.

No.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2012-07-06  1:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-04 19:13 3.5.0-rc5: inconsistent lock state Christian Kujau
2012-07-04 19:14 ` Christian Kujau
2012-07-05  7:43 ` Christoph Hellwig
2012-07-05 12:44   ` Christian Kujau
2012-07-05 21:59     ` Dave Chinner
2012-07-05 23:39       ` Christian Kujau
2012-07-06  1:01         ` Dave Chinner [this message]
2012-07-06  1:55           ` Christian Kujau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120706010126.GT19223@dastard \
    --to=david@fromorbit.com \
    --cc=hch@infradead.org \
    --cc=lists@nerdbynature.de \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.