From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755258Ab2GIPVB (ORCPT ); Mon, 9 Jul 2012 11:21:01 -0400 Received: from cantor2.suse.de ([195.135.220.15]:44854 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753909Ab2GIPU7 (ORCPT ); Mon, 9 Jul 2012 11:20:59 -0400 Date: Mon, 9 Jul 2012 17:20:58 +0200 From: Michal Hocko To: Johannes Weiner Cc: Andrew Morton , KAMEZAWA Hiroyuki , Hugh Dickins , David Rientjes , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [patch 08/11] mm: memcg: remove needless !mm fixup to init_mm when charging Message-ID: <20120709152058.GK4627@tiehlicka.suse.cz> References: <1341449103-1986-1-git-send-email-hannes@cmpxchg.org> <1341449103-1986-9-git-send-email-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1341449103-1986-9-git-send-email-hannes@cmpxchg.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 05-07-12 02:45:00, Johannes Weiner wrote: > It does not matter to __mem_cgroup_try_charge() if the passed mm is > NULL or init_mm, it will charge the root memcg in either case. > > Signed-off-by: Johannes Weiner Acked-by: Michal Hocko > --- > mm/memcontrol.c | 5 ----- > 1 files changed, 0 insertions(+), 5 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 418b47d..6fe4101 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -2766,8 +2766,6 @@ int mem_cgroup_try_charge_swapin(struct mm_struct *mm, > ret = 0; > return ret; > charge_cur_mm: > - if (unlikely(!mm)) > - mm = &init_mm; > ret = __mem_cgroup_try_charge(mm, mask, 1, memcgp, true); > if (ret == -EINTR) > ret = 0; > @@ -2832,9 +2830,6 @@ int mem_cgroup_cache_charge(struct page *page, struct mm_struct *mm, > if (PageCompound(page)) > return 0; > > - if (unlikely(!mm)) > - mm = &init_mm; > - > if (!PageSwapCache(page)) > ret = mem_cgroup_charge_common(page, mm, gfp_mask, type); > else { /* page is swapcache/shmem */ > -- > 1.7.7.6 > -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx207.postini.com [74.125.245.207]) by kanga.kvack.org (Postfix) with SMTP id 9C66E6B006E for ; Mon, 9 Jul 2012 11:21:00 -0400 (EDT) Date: Mon, 9 Jul 2012 17:20:58 +0200 From: Michal Hocko Subject: Re: [patch 08/11] mm: memcg: remove needless !mm fixup to init_mm when charging Message-ID: <20120709152058.GK4627@tiehlicka.suse.cz> References: <1341449103-1986-1-git-send-email-hannes@cmpxchg.org> <1341449103-1986-9-git-send-email-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1341449103-1986-9-git-send-email-hannes@cmpxchg.org> Sender: owner-linux-mm@kvack.org List-ID: To: Johannes Weiner Cc: Andrew Morton , KAMEZAWA Hiroyuki , Hugh Dickins , David Rientjes , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org On Thu 05-07-12 02:45:00, Johannes Weiner wrote: > It does not matter to __mem_cgroup_try_charge() if the passed mm is > NULL or init_mm, it will charge the root memcg in either case. > > Signed-off-by: Johannes Weiner Acked-by: Michal Hocko > --- > mm/memcontrol.c | 5 ----- > 1 files changed, 0 insertions(+), 5 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 418b47d..6fe4101 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -2766,8 +2766,6 @@ int mem_cgroup_try_charge_swapin(struct mm_struct *mm, > ret = 0; > return ret; > charge_cur_mm: > - if (unlikely(!mm)) > - mm = &init_mm; > ret = __mem_cgroup_try_charge(mm, mask, 1, memcgp, true); > if (ret == -EINTR) > ret = 0; > @@ -2832,9 +2830,6 @@ int mem_cgroup_cache_charge(struct page *page, struct mm_struct *mm, > if (PageCompound(page)) > return 0; > > - if (unlikely(!mm)) > - mm = &init_mm; > - > if (!PageSwapCache(page)) > ret = mem_cgroup_charge_common(page, mm, gfp_mask, type); > else { /* page is swapcache/shmem */ > -- > 1.7.7.6 > -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Hocko Subject: Re: [patch 08/11] mm: memcg: remove needless !mm fixup to init_mm when charging Date: Mon, 9 Jul 2012 17:20:58 +0200 Message-ID: <20120709152058.GK4627@tiehlicka.suse.cz> References: <1341449103-1986-1-git-send-email-hannes@cmpxchg.org> <1341449103-1986-9-git-send-email-hannes@cmpxchg.org> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <1341449103-1986-9-git-send-email-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Johannes Weiner Cc: Andrew Morton , KAMEZAWA Hiroyuki , Hugh Dickins , David Rientjes , linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Thu 05-07-12 02:45:00, Johannes Weiner wrote: > It does not matter to __mem_cgroup_try_charge() if the passed mm is > NULL or init_mm, it will charge the root memcg in either case. > > Signed-off-by: Johannes Weiner Acked-by: Michal Hocko > --- > mm/memcontrol.c | 5 ----- > 1 files changed, 0 insertions(+), 5 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 418b47d..6fe4101 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -2766,8 +2766,6 @@ int mem_cgroup_try_charge_swapin(struct mm_struct *mm, > ret = 0; > return ret; > charge_cur_mm: > - if (unlikely(!mm)) > - mm = &init_mm; > ret = __mem_cgroup_try_charge(mm, mask, 1, memcgp, true); > if (ret == -EINTR) > ret = 0; > @@ -2832,9 +2830,6 @@ int mem_cgroup_cache_charge(struct page *page, struct mm_struct *mm, > if (PageCompound(page)) > return 0; > > - if (unlikely(!mm)) > - mm = &init_mm; > - > if (!PageSwapCache(page)) > ret = mem_cgroup_charge_common(page, mm, gfp_mask, type); > else { /* page is swapcache/shmem */ > -- > 1.7.7.6 > -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic