All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: jdmason@kudzu.us
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] vxge/s2io: remove dead URLs
Date: Tue, 10 Jul 2012 23:21:45 -0700 (PDT)	[thread overview]
Message-ID: <20120710.232145.512531453311572431.davem@davemloft.net> (raw)
In-Reply-To: <20120710.231832.391247031231469078.davem@davemloft.net>

From: David Miller <davem@davemloft.net>
Date: Tue, 10 Jul 2012 23:18:32 -0700 (PDT)

> From: Jon Mason <jdmason@kudzu.us>
> Date: Mon,  9 Jul 2012 17:07:57 -0700
> 
>> URLs to neterion.com and s2io.com no longer resolve.  Remove all references to
>> these URLs in the driver source and documentation.
>> 
>> Signed-off-by: Jon Mason <jdmason@kudzu.us>
> 
> Applied, but I had to fix:
> 
>> -7. Support 
>> +6. Support 
>              ^^
> 
> that trailing whitespace.

Wow you didn't even build test this patch, otherwise you would have
seen:

drivers/net/ethernet/neterion/vxge/vxge-main.c: In function ‘vxge_probe_fw_update’:
drivers/net/ethernet/neterion/vxge/vxge-main.c:4263:3: warning: format ‘%s’ expects argument of type ‘char *’, but argument 2 has type ‘u32’ [-Wformat]
drivers/net/ethernet/neterion/vxge/vxge-main.c:4263:3: warning: format ‘%d’ expects a matching ‘int’ argument [-Wformat]

I'm fixing this up, but next time this will put you on my shit
list for sure.

      reply	other threads:[~2012-07-11  6:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-10  0:07 [PATCH] vxge/s2io: remove dead URLs Jon Mason
2012-07-11  6:18 ` David Miller
2012-07-11  6:21   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120710.232145.512531453311572431.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=jdmason@kudzu.us \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.