All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Supriya Kannery <supriyak@linux.vnet.ibm.com>,
	Shrinidhi Joshi <spjoshi31@gmail.com>,
	Stefan Hajnoczi <stefanha@gmail.com>,
	Jeff Cody <jcody@redhat.com>,
	qemu-devel@nongnu.org, Eric Blake <eblake@redhat.com>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [v1 Patch 1/10]Qemu: Enhance "info block" to display host cache setting
Date: Wed, 11 Jul 2012 11:03:19 -0300	[thread overview]
Message-ID: <20120711110319.4c1dc584@doriath.home> (raw)
In-Reply-To: <4FFAEE1C.2050607@redhat.com>

On Mon, 09 Jul 2012 16:43:40 +0200
Kevin Wolf <kwolf@redhat.com> wrote:

> Am 15.06.2012 23:07, schrieb Eric Blake:
> > On 06/15/2012 02:47 PM, Supriya Kannery wrote:
> >> Enhance "info block" to display hostcache setting for each
> >> block device.
> >>
> > 
> >>  ##
> >>  { 'type': 'BlockInfo',
> >>    'data': {'device': 'str', 'type': 'str', 'removable': 'bool',
> >> -           'locked': 'bool', '*inserted': 'BlockDeviceInfo',
> >> +           'locked': 'bool','hostcache': 'bool', '*inserted': 'BlockDeviceInfo',
> > 
> > space after comma
> > 
> > Since 'hostcache' was not present when talking to older qemu, should we
> > mark it optional?
> 
> What does "optional" really mean? I always understood that it means that
> whether the field exists or not depends on some runtime condition, not
> on the qemu version. I would specify something like this, that always
> exists in new qemu versions, in the "Since" section. Or maybe a separate
> "Since" specification like in SpiceInfo for mouse-mode.

Yes, Kevin is right.

  reply	other threads:[~2012-07-11 14:04 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-15 20:46 [Qemu-devel] [v1 Patch 0/10]Qemu: Dynamic host pagecache change and image file reopen Supriya Kannery
2012-06-15 20:47 ` [Qemu-devel] [v1 Patch 1/10]Qemu: Enhance "info block" to display host cache setting Supriya Kannery
2012-06-15 21:07   ` Eric Blake
2012-07-09 14:43     ` Kevin Wolf
2012-07-11 14:03       ` Luiz Capitulino [this message]
2012-07-29  6:21         ` Supriya Kannery
2012-07-05 16:38   ` Jeff Cody
2012-07-29  6:54     ` Supriya Kannery
2012-06-15 20:47 ` [Qemu-devel] [v1 Patch 2/10]Qemu: Error classes for hostcache setting and data sync failures Supriya Kannery
2012-07-09 14:47   ` Kevin Wolf
2012-07-29  6:58     ` Supriya Kannery
2012-06-15 20:47 ` [Qemu-devel] [v1 Patch 3/10]Qemu: Cmd "block_set_hostcache" for dynamic cache change Supriya Kannery
2012-06-15 21:56   ` Eric Blake
2012-07-29  7:33     ` Supriya Kannery
2012-06-20 18:18   ` Jeff Cody
2012-07-04  5:10     ` Shrinidhi Joshi
2012-07-04  6:30       ` Kevin Wolf
2012-07-09 14:52   ` Kevin Wolf
2012-07-11 14:16   ` Luiz Capitulino
2012-07-29  7:56     ` Supriya Kannery
2012-06-15 20:47 ` [Qemu-devel] [v1 Patch 4/10]Qemu: Framework for reopening image files safely Supriya Kannery
2012-06-15 22:02   ` Eric Blake
2012-07-09 15:06   ` Kevin Wolf
2012-06-15 20:48 ` [Qemu-devel] [v1 Patch 5/10]Qemu: raw-posix image file reopen Supriya Kannery
2012-06-15 22:11   ` Eric Blake
2012-07-04  5:15     ` Shrinidhi Joshi
2012-07-04 11:32       ` Eric Blake
2012-06-15 20:48 ` [Qemu-devel] [v1 Patch 6/10]Qemu: raw-win32 " Supriya Kannery
2012-06-15 20:48 ` [Qemu-devel] [v1 Patch 7/10]Qemu: vmdk " Supriya Kannery
2012-06-15 20:48 ` [Qemu-devel] [v1 Patch 8/10]Qemu: qcow2 " Supriya Kannery
2012-06-15 20:48 ` [Qemu-devel] [v1 Patch 9/10]Qemu: qcow " Supriya Kannery
2012-06-15 20:49 ` [Qemu-devel] [v1 Patch 10/10]Qemu: qed " Supriya Kannery
2012-07-09 17:51 ` [Qemu-devel] [v1 Patch 0/10]Qemu: Dynamic host pagecache change and " Stefan Weil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120711110319.4c1dc584@doriath.home \
    --to=lcapitulino@redhat.com \
    --cc=eblake@redhat.com \
    --cc=hch@lst.de \
    --cc=jcody@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=spjoshi31@gmail.com \
    --cc=stefanha@gmail.com \
    --cc=supriyak@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.