From: jamie@jamieiles.com (Jamie Iles)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] clocksource: dw_apb_timer: Add common DTS glue for dw_apb_timer
Date: Wed, 11 Jul 2012 17:03:58 +0100 [thread overview]
Message-ID: <20120711160358.GA8444@page> (raw)
In-Reply-To: <1342020026.4790.1.camel@dinguyen-VirtualBox>
On Wed, Jul 11, 2012 at 10:20:26AM -0500, Dinh Nguyen wrote:
> On Wed, 2012-07-11 at 00:15 +0100, Jamie Iles wrote:
> > On Tue, Jul 10, 2012 at 04:39:40PM -0500, dinguyen at altera.com wrote:
> > > --- a/arch/arm/mach-picoxcell/time.c
> > > +++ b/drivers/clocksource/dw_apb_timer_of.c
> > > @@ -1,11 +1,20 @@
> > [...]
> > > -static const struct of_device_id picoxcell_rtc_ids[] __initconst = {
> > > - { .compatible = "picochip,pc3x2-rtc" },
> > > +static const struct of_device_id sptimer_ids[] __initconst = {
> > > + { .compatible = "snps,dw-apb-timer-sp" },
> > > { /* Sentinel */ },
> >
> > Please keep picochip,pc3x2-rtc in the compatible list otherwise we won't
> > boot any more.
>
> Should I add another .compatible entry here, or make the change in
> picoxcell-pc3x2 and picoxcell-pc3x3 dtsi files?
I think that adding another compatible entry is the right thing to do
here - it avoids churn of the dtsi files and means that the compiled
device-tree blobs on deployed devices won't need updating.
Jamie
next prev parent reply other threads:[~2012-07-11 16:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-10 21:39 [PATCH v2 1/2] clocksource: dw_apb_timer: Add common DTS glue for dw_apb_timer dinguyen at altera.com
2012-07-10 21:39 ` [PATCH v2 2/2] arm: picoxcell: Make use of dw_apb_timer_of dinguyen at altera.com
2012-07-10 23:15 ` [PATCH v2 1/2] clocksource: dw_apb_timer: Add common DTS glue for dw_apb_timer Jamie Iles
2012-07-11 15:20 ` Dinh Nguyen
2012-07-11 16:03 ` Jamie Iles [this message]
2012-07-11 16:23 ` Pavel Machek
2012-07-11 16:32 ` Dinh Nguyen
2012-07-11 1:39 ` Rob Herring
2012-07-11 15:21 ` Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120711160358.GA8444@page \
--to=jamie@jamieiles.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.