From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vasilis Liaskovitis Subject: Re: [Qemu-devel] [RFC PATCH v2 19/21] Implement "info memtotal" and "query-memtotal" Date: Wed, 11 Jul 2012 18:55:15 +0200 Message-ID: <20120711165515.GE15407@dhcp-192-168-178-175.profitbricks.localdomain> References: <1342002726-18258-1-git-send-email-vasilis.liaskovitis@profitbricks.com> <1342002726-18258-20-git-send-email-vasilis.liaskovitis@profitbricks.com> <4FFD9855.1010902@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, seabios@seabios.org, qemu-devel@nongnu.org, avi@redhat.com To: Eric Blake Return-path: Content-Disposition: inline In-Reply-To: <4FFD9855.1010902@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: seabios-bounces@seabios.org Sender: seabios-bounces@seabios.org List-Id: kvm.vger.kernel.org Hi, On Wed, Jul 11, 2012 at 09:14:29AM -0600, Eric Blake wrote: > On 07/11/2012 04:32 AM, Vasilis Liaskovitis wrote: > > Returns total memory of guest in bytes, including hotplugged memory. > > > > Signed-off-by: Vasilis Liaskovitis > > Should this instead be merged with query-balloon output, so that we have > a single command that shows all aspects of memory usage (both balloon > and hotplug at once)? > > > > @@ -1888,3 +1888,15 @@ > > # Since: 1.1.3 > > ## > > { 'command': 'query-memhp', 'returns': ['MemHpInfo'] } > > + > > +## > > +# @query-memtotal: > > A more generic name might be 'query-memory', especially if we merge > balloon and hotplug information into one command. "query-memory" sounds reasonable to me. "query-balloon" should also be updated to show the correct memory. Do you foresee any issues with merging them? the "query-memory" command should work independently of the balloon driver. > > +# > > +# Returns total memory in bytes, including hotplugged dimms > > +# > > +# Returns: a l > > truncated sorry about that. thanks, - Vasilis > > -- > Eric Blake eblake@redhat.com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45857) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sp0CF-0007Up-3F for qemu-devel@nongnu.org; Wed, 11 Jul 2012 12:55:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sp0C8-0002XG-Sd for qemu-devel@nongnu.org; Wed, 11 Jul 2012 12:55:26 -0400 Received: from mail-bk0-f45.google.com ([209.85.214.45]:38599) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sp0C8-0002Wh-Lv for qemu-devel@nongnu.org; Wed, 11 Jul 2012 12:55:20 -0400 Received: by bkcji1 with SMTP id ji1so1095291bkc.4 for ; Wed, 11 Jul 2012 09:55:18 -0700 (PDT) Date: Wed, 11 Jul 2012 18:55:15 +0200 From: Vasilis Liaskovitis Message-ID: <20120711165515.GE15407@dhcp-192-168-178-175.profitbricks.localdomain> References: <1342002726-18258-1-git-send-email-vasilis.liaskovitis@profitbricks.com> <1342002726-18258-20-git-send-email-vasilis.liaskovitis@profitbricks.com> <4FFD9855.1010902@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4FFD9855.1010902@redhat.com> Subject: Re: [Qemu-devel] [RFC PATCH v2 19/21] Implement "info memtotal" and "query-memtotal" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kvm@vger.kernel.org, gleb@redhat.com, seabios@seabios.org, qemu-devel@nongnu.org, kevin@koconnor.net, avi@redhat.com, anthony@codemonkey.ws, imammedo@redhat.com Hi, On Wed, Jul 11, 2012 at 09:14:29AM -0600, Eric Blake wrote: > On 07/11/2012 04:32 AM, Vasilis Liaskovitis wrote: > > Returns total memory of guest in bytes, including hotplugged memory. > > > > Signed-off-by: Vasilis Liaskovitis > > Should this instead be merged with query-balloon output, so that we have > a single command that shows all aspects of memory usage (both balloon > and hotplug at once)? > > > > @@ -1888,3 +1888,15 @@ > > # Since: 1.1.3 > > ## > > { 'command': 'query-memhp', 'returns': ['MemHpInfo'] } > > + > > +## > > +# @query-memtotal: > > A more generic name might be 'query-memory', especially if we merge > balloon and hotplug information into one command. "query-memory" sounds reasonable to me. "query-balloon" should also be updated to show the correct memory. Do you foresee any issues with merging them? the "query-memory" command should work independently of the balloon driver. > > +# > > +# Returns total memory in bytes, including hotplugged dimms > > +# > > +# Returns: a l > > truncated sorry about that. thanks, - Vasilis > > -- > Eric Blake eblake@redhat.com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org > > >