All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad@darnok.org>
To: Seth Jennings <sjenning@linux.vnet.ibm.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Dan Magenheimer <dan.magenheimer@oracle.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Nitin Gupta <ngupta@vflare.org>, Minchan Kim <minchan@kernel.org>,
	Robert Jennings <rcj@linux.vnet.ibm.com>,
	linux-mm@kvack.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] zsmalloc improvements
Date: Thu, 12 Jul 2012 06:40:30 -0400	[thread overview]
Message-ID: <20120712104029.GA3920@konrad-lan.dumpdata.com> (raw)
In-Reply-To: <4FFDE69C.8080205@linux.vnet.ibm.com>

On Wed, Jul 11, 2012 at 03:48:28PM -0500, Seth Jennings wrote:
> On 07/11/2012 02:42 PM, Konrad Rzeszutek Wilk wrote:
> >>>> Which architecture was this under? It sounds x86-ish? Is this on
> >>>> Westmere and more modern machines? What about Core2 architecture?
> >>>>
> >>>> Oh how did it work on AMD Phenom boxes?
> >>>
> >>> I don't have a Phenom box but I have an Athlon X2 I can try out.
> >>> I'll get this information next Monday.
> >>
> >> Actually, I'm running some production stuff on that box, so
> >> I rather not put testing stuff on it.  Is there any
> >> particular reason that you wanted this information? Do you
> >> have a reason to believe that mapping will be faster than
> >> copy for AMD procs?
> > 
> > Sorry for the late response. Working on some ugly bug that is taking
> > more time than anticipated.
> > My thoughts were that these findings are based on the hardware memory
> > prefetcher. The Intel
> > machines - especially starting with Nehelem have some pretty
> > impressive prefetcher where
> > even doing in a linked list 'prefetch' on the next node is not beneficial.
> > 
> > Perhaps the way to leverage this is to use different modes depending
> > on the bulk of data?
> > When there is a huge amount use the old method, but for small use copy
> > (as it would
> > in theory stay in the cache longer).
> 
> Not sure what you mean by "bulk" or "huge amount" but the
> maximum size of mapped object is PAGE_SIZE and the typical
> size more around PAGE_SIZE/2. So that is what I'm
> considering.  Do you think it makes a difference with copies
> that small?

I was thinking in terms of time. So if there are many requests coming
in at some threshold, then use one method.
> 
> Thanks,
> Seth
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
> 

WARNING: multiple messages have this Message-ID
From: Konrad Rzeszutek Wilk <konrad@darnok.org>
To: Seth Jennings <sjenning@linux.vnet.ibm.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Dan Magenheimer <dan.magenheimer@oracle.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Nitin Gupta <ngupta@vflare.org>, Minchan Kim <minchan@kernel.org>,
	Robert Jennings <rcj@linux.vnet.ibm.com>,
	linux-mm@kvack.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] zsmalloc improvements
Date: Thu, 12 Jul 2012 06:40:30 -0400	[thread overview]
Message-ID: <20120712104029.GA3920@konrad-lan.dumpdata.com> (raw)
In-Reply-To: <4FFDE69C.8080205@linux.vnet.ibm.com>

On Wed, Jul 11, 2012 at 03:48:28PM -0500, Seth Jennings wrote:
> On 07/11/2012 02:42 PM, Konrad Rzeszutek Wilk wrote:
> >>>> Which architecture was this under? It sounds x86-ish? Is this on
> >>>> Westmere and more modern machines? What about Core2 architecture?
> >>>>
> >>>> Oh how did it work on AMD Phenom boxes?
> >>>
> >>> I don't have a Phenom box but I have an Athlon X2 I can try out.
> >>> I'll get this information next Monday.
> >>
> >> Actually, I'm running some production stuff on that box, so
> >> I rather not put testing stuff on it.  Is there any
> >> particular reason that you wanted this information? Do you
> >> have a reason to believe that mapping will be faster than
> >> copy for AMD procs?
> > 
> > Sorry for the late response. Working on some ugly bug that is taking
> > more time than anticipated.
> > My thoughts were that these findings are based on the hardware memory
> > prefetcher. The Intel
> > machines - especially starting with Nehelem have some pretty
> > impressive prefetcher where
> > even doing in a linked list 'prefetch' on the next node is not beneficial.
> > 
> > Perhaps the way to leverage this is to use different modes depending
> > on the bulk of data?
> > When there is a huge amount use the old method, but for small use copy
> > (as it would
> > in theory stay in the cache longer).
> 
> Not sure what you mean by "bulk" or "huge amount" but the
> maximum size of mapped object is PAGE_SIZE and the typical
> size more around PAGE_SIZE/2. So that is what I'm
> considering.  Do you think it makes a difference with copies
> that small?

I was thinking in terms of time. So if there are many requests coming
in at some threshold, then use one method.
> 
> Thanks,
> Seth
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
> 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2012-07-12 10:40 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-02 21:15 Seth Jennings
2012-07-02 21:15 ` Seth Jennings
2012-07-02 21:15 ` [PATCH 1/4] zsmalloc: remove x86 dependency Seth Jennings
2012-07-02 21:15   ` Seth Jennings
2012-07-10  2:21   ` Minchan Kim
2012-07-10  2:21     ` Minchan Kim
2012-07-10 15:29     ` Seth Jennings
2012-07-10 15:29       ` Seth Jennings
2012-07-11  7:27       ` Minchan Kim
2012-07-11  7:27         ` Minchan Kim
2012-07-11 18:26   ` Nitin Gupta
2012-07-11 18:26     ` Nitin Gupta
2012-07-11 20:32     ` Seth Jennings
2012-07-11 20:32       ` Seth Jennings
2012-07-11 22:42       ` Nitin Gupta
2012-07-11 22:42         ` Nitin Gupta
2012-07-12  0:23         ` Seth Jennings
2012-07-12  0:23           ` Seth Jennings
2012-07-02 21:15 ` [PATCH 2/4] zsmalloc: add single-page object fastpath in unmap Seth Jennings
2012-07-02 21:15   ` Seth Jennings
2012-07-10  2:25   ` Minchan Kim
2012-07-10  2:25     ` Minchan Kim
2012-07-02 21:15 ` [PATCH 3/4] zsmalloc: add details to zs_map_object boiler plate Seth Jennings
2012-07-02 21:15   ` Seth Jennings
2012-07-10  2:35   ` Minchan Kim
2012-07-10  2:35     ` Minchan Kim
2012-07-10 15:17     ` Seth Jennings
2012-07-10 15:17       ` Seth Jennings
2012-07-11  7:42       ` Minchan Kim
2012-07-11  7:42         ` Minchan Kim
2012-07-11 14:15         ` Seth Jennings
2012-07-11 14:15           ` Seth Jennings
2012-07-12  1:15           ` Minchan Kim
2012-07-12  1:15             ` Minchan Kim
2012-07-12 19:54             ` Dan Magenheimer
2012-07-12 19:54               ` Dan Magenheimer
2012-07-12 22:46               ` Dan Magenheimer
2012-07-12 22:46                 ` Dan Magenheimer
2012-07-02 21:15 ` [PATCH 4/4] zsmalloc: add mapping modes Seth Jennings
2012-07-02 21:15   ` Seth Jennings
2012-07-04  5:33 ` [PATCH 0/4] zsmalloc improvements Minchan Kim
2012-07-04  5:33   ` Minchan Kim
2012-07-04 20:43 ` Konrad Rzeszutek Wilk
2012-07-04 20:43   ` Konrad Rzeszutek Wilk
2012-07-06 15:07   ` Seth Jennings
2012-07-06 15:07     ` Seth Jennings
2012-07-09 13:58     ` Seth Jennings
2012-07-09 13:58       ` Seth Jennings
2012-07-11 19:42       ` Konrad Rzeszutek Wilk
2012-07-11 19:42         ` Konrad Rzeszutek Wilk
2012-07-11 20:48         ` Seth Jennings
2012-07-11 20:48           ` Seth Jennings
2012-07-12 10:40           ` Konrad Rzeszutek Wilk [this message]
2012-07-12 10:40             ` Konrad Rzeszutek Wilk
2012-07-11  7:03 ` Minchan Kim
2012-07-11  7:03   ` Minchan Kim
2012-07-11 14:00   ` Seth Jennings
2012-07-11 14:00     ` Seth Jennings
2012-07-12  1:01     ` Minchan Kim
2012-07-12  1:01       ` Minchan Kim
2012-07-11 19:16   ` Seth Jennings
2012-07-11 19:16     ` Seth Jennings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120712104029.GA3920@konrad-lan.dumpdata.com \
    --to=konrad@darnok.org \
    --cc=akpm@linux-foundation.org \
    --cc=dan.magenheimer@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    --cc=ngupta@vflare.org \
    --cc=rcj@linux.vnet.ibm.com \
    --cc=sjenning@linux.vnet.ibm.com \
    --subject='Re: [PATCH 0/4] zsmalloc improvements' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.