All of lore.kernel.org
 help / color / mirror / Atom feed
* [merged] drivers-rtc-rtc-twlc-fix-threaded-irq-to-use-irqf_oneshot.patch removed from -mm tree
@ 2012-07-12 19:37 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2012-07-12 19:37 UTC (permalink / raw)
  To: khilman, a.zummo, tglx, mm-commits


The patch titled
     Subject: drivers/rtc/rtc-twl.c: fix threaded IRQ to use IRQF_ONESHOT
has been removed from the -mm tree.  Its filename was
     drivers-rtc-rtc-twlc-fix-threaded-irq-to-use-irqf_oneshot.patch

This patch was dropped because it was merged into mainline or a subsystem tree

------------------------------------------------------
From: Kevin Hilman <khilman@ti.com>
Subject: drivers/rtc/rtc-twl.c: fix threaded IRQ to use IRQF_ONESHOT

Requesting a threaded interrupt without a primary handler and without
IRQF_ONESHOT is dangerous, and after commit 1c6c6952 ("genirq: Reject
bogus threaded irq requests"), these requests are rejected.  This causes
->probe() to fail, and the RTC driver not to be availble.

To fix, add IRQF_ONESHOT to the IRQ flags.

Tested on OMAP3730/OveroSTORM and OMAP4430/Panda board using rtcwake to
wake from system suspend multiple times.

Signed-off-by: Kevin Hilman <khilman@ti.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/rtc/rtc-twl.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/rtc/rtc-twl.c~drivers-rtc-rtc-twlc-fix-threaded-irq-to-use-irqf_oneshot drivers/rtc/rtc-twl.c
--- a/drivers/rtc/rtc-twl.c~drivers-rtc-rtc-twlc-fix-threaded-irq-to-use-irqf_oneshot
+++ a/drivers/rtc/rtc-twl.c
@@ -510,7 +510,7 @@ static int __devinit twl_rtc_probe(struc
 	}
 
 	ret = request_threaded_irq(irq, NULL, twl_rtc_interrupt,
-				   IRQF_TRIGGER_RISING,
+				   IRQF_TRIGGER_RISING | IRQF_ONESHOT,
 				   dev_name(&rtc->dev), rtc);
 	if (ret < 0) {
 		dev_err(&pdev->dev, "IRQ is not free.\n");
_

Patches currently in -mm which might be from khilman@ti.com are

origin.patch
linux-next.patch


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2012-07-12 19:37 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-12 19:37 [merged] drivers-rtc-rtc-twlc-fix-threaded-irq-to-use-irqf_oneshot.patch removed from -mm tree akpm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.